Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-939 assign groups to course #3326

Merged
merged 19 commits into from
Oct 16, 2023
Merged

N21-939 assign groups to course #3326

merged 19 commits into from
Oct 16, 2023

Conversation

MBergCap
Copy link
Contributor

@MBergCap MBergCap commented Oct 9, 2023 •
edited
Loading

groups of type class can be added to a course

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-939
hpi-schul-cloud/nuxt-client#2854
hpi-schul-cloud/schulcloud-server#4464
hpi-schul-cloud/dof_app_deploy#661

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MBergCap MBergCap changed the title N21 939 assign groups to course N21-939 assign groups to course Oct 9, 2023
@MBergCap MBergCap added the WIP label Oct 9, 2023
arnegns
arnegns suggested changes Oct 9, 2023
View reviewed changes
controllers/courses.js Show resolved Hide resolved
config/default.schema.json Show resolved Hide resolved
@IgorCapCoder IgorCapCoder mentioned this pull request Oct 9, 2023
Merged
3 tasks
arnegns
arnegns reviewed Oct 9, 2023
View reviewed changes
controllers/courses.js Outdated Show resolved Hide resolved
arnegns
arnegns reviewed Oct 9, 2023
View reviewed changes
controllers/courses.js Outdated Show resolved Hide resolved
This was referenced Oct 11, 2023
Merged
Merged
@MBergCap MBergCap removed the WIP label Oct 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mrikallab mrikallab enabled auto-merge (squash) October 16, 2023 13:13
@mrikallab mrikallab merged commit 471f3e7 into main Oct 16, 2023
37 of 38 checks passed
@mrikallab mrikallab deleted the N21-939-assign-groups-to-course branch October 16, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBergCap @arnegns @mrikallab