Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6097 - fix filter when school has no system #3375

Merged
merged 1 commit into from
Dec 21, 2023
Merged

BC-6097 - fix filter when school has no system #3375

merged 1 commit into from
Dec 21, 2023

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Dec 20, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

BC-6097

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@virgilchiriac virgilchiriac merged commit 4aca15b into main Dec 21, 2023
40 of 41 checks passed
@virgilchiriac virgilchiriac deleted the BC-6097-fix-login branch December 21, 2023 12:05
virgilchiriac added a commit that referenced this pull request Dec 21, 2023
@virgilchiriac
BC-6097 - fix filter when school has no system (#3375)
548c3da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgilchiriac @SevenWaysDP