Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6292 using wget as the k8s http probes were not failing #3390

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Jan 18, 2024

hopefully this is a workaround for a problem that we can not fully identifiy
we can only pin point it to the k8s probe itself, if it is the k8s version, the affected version would be v1.26.11

to try it out, stop or restart redis, try the probe, it will fail, where the k8s http-get one succeeds

Description

Links to Tickets or other pull requests

BC-6292

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

hopefully this is a workaround for a problem that we can not fully
identifiy
we can only pin point it to the k8s probe itself, if it is the k8s
version, the affected version would be v1.26.11
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Loki-Afro Loki-Afro merged commit e31a320 into main Jan 18, 2024
42 checks passed
@Loki-Afro Loki-Afro deleted the bc-6292-workaround-for-not-failing-probes branch January 18, 2024 15:01
virgilchiriac pushed a commit that referenced this pull request Jan 19, 2024
hopefully this is a workaround for a problem that we can not fully
identifiy
we can only pin point it to the k8s probe itself, if it is the k8s
version, the affected version would be v1.26.11
@Loki-Afro
Copy link
Member Author

Loki-Afro commented Jan 24, 2024

related to this issue kubernetes/kubernetes#122948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants