Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6352 - Deleting the creator field causes the files not to be displayed anymore #3396

Merged
merged 9 commits into from
Mar 8, 2024
Merged

BC-6352 - Deleting the creator field causes the files not to be displayed anymore #3396

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ad03b0
remove creator ID filtering (that allows only the teachers and submit…
bn-pass Jan 24, 2024
7fbb290
Merge branch 'main' into BC-6352-no-creator-ref-case
bn-pass Feb 4, 2024
e824132
Merge branch 'main' into BC-6352-no-creator-ref-case
bn-pass Feb 7, 2024
0441ba6
Merge branch 'main' into BC-6352-no-creator-ref-case
bn-pass Feb 8, 2024
334602c
Merge branch 'main' into BC-6352-no-creator-ref-case
bn-pass Feb 12, 2024
3a2f375
Merge branch 'main' into BC-6352-no-creator-ref-case
bn-pass Feb 13, 2024
67b3532
Merge branch 'main' into BC-6352-no-creator-ref-case
bn-pass Feb 15, 2024
50a75be
Merge branch 'main' into BC-6352-no-creator-ref-case
bn-pass Mar 8, 2024
4e555a6
modify the creatorId-based filter to be applied only for the files th…
bn-pass Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/homework.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,11 +595,11 @@ router.get('/:assignmentId', (req, res, next) => {
}

const submissionFilesStorageData = _.clone(filesStorage);
submissionFilesStorageData.files = filesStorage.files.filter((file) => submitters.has(file.creatorId));
submissionFilesStorageData.files = filesStorage.files.filter((file) => !file.creatorId || submitters.has(file.creatorId));
submissionFilesStorageData.readonly = readonly || (!isCreator && isTeacher);

const gradeFilesStorageData = _.clone(filesStorage);
gradeFilesStorageData.files = filesStorage.files.filter((file) => teachers.has(file.creatorId));
gradeFilesStorageData.files = filesStorage.files.filter((file) => !file.creatorId || teachers.has(file.creatorId));
gradeFilesStorageData.readonly = !isTeacher;

submission.submissionFiles = { filesStorage: submissionFilesStorageData };
Expand Down
Loading