Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4784 Use api/v3 for getting schools for login #3397

Merged
merged 8 commits into from
Feb 5, 2024

Conversation

dyedwiper
Copy link
Contributor

@dyedwiper dyedwiper commented Jan 25, 2024

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4784

hpi-schul-cloud/schulcloud-server#4718
hpi-schul-cloud/nuxt-client#3061

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dyedwiper dyedwiper merged commit f5cb13b into main Feb 5, 2024
41 of 42 checks passed
@dyedwiper dyedwiper deleted the bc-4784-migrate-schools-list branch February 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants