Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1774 create synced course #3426

Merged
merged 23 commits into from
Apr 8, 2024
Merged

N21-1774 create synced course #3426

merged 23 commits into from
Apr 8, 2024

Conversation

MBergCap
Copy link
Contributor

@MBergCap MBergCap commented Mar 15, 2024 •
edited by IgorCapCoder
Loading

Description

Links to Tickets or other pull requests

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@IgorCapCoder IgorCapCoder mentioned this pull request Mar 18, 2024
Merged
3 tasks
@IgorCapCoder IgorCapCoder mentioned this pull request Mar 18, 2024
Merged
1 task
@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Mar 19, 2024
Merged
3 tasks
arnegns
arnegns suggested changes Mar 19, 2024
View reviewed changes
controllers/courses.js Outdated Show resolved Hide resolved
@IgorCapCoder
Merge branch 'main' into N21-1774-create-synced-course
2b13900 
# Conflicts:
#	config/default.schema.json
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IgorCapCoder IgorCapCoder enabled auto-merge (squash) April 8, 2024 14:17
@IgorCapCoder IgorCapCoder merged commit f0dfe2b into main Apr 8, 2024
45 of 46 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1774-create-synced-course branch April 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MBergCap @arnegns @MarvinOehlerkingCap @IgorCapCoder