Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6672 fix incorrect translation in alert #3427

Merged
merged 8 commits into from
Mar 22, 2024
Merged

BC-6672 fix incorrect translation in alert #3427

merged 8 commits into from
Mar 22, 2024

Conversation

MichalNers
Copy link
Contributor

@MichalNers MichalNers commented Mar 18, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

bn-pass
bn-pass suggested changes Mar 19, 2024
View reviewed changes
.prettierrc.js Outdated Show resolved Hide resolved
helpers/momentHelper.js Show resolved Hide resolved
locales/calendar/es.json Outdated Show resolved Hide resolved
@MichalNers MichalNers requested a review from bn-pass March 20, 2024 08:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MichalNers MichalNers merged commit c635e8f into main Mar 22, 2024
46 of 47 checks passed
@MichalNers MichalNers deleted the BC-6672-fix-incorrect-alert-translation branch March 22, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn-pass bn-pass bn-pass approved these changes

@CeEv CeEv CeEv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalNers @CeEv @bn-pass