Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6752 - Fix H5P editor loading #3429

Merged
merged 1 commit into from
Mar 20, 2024
Merged

BC-6752 - Fix H5P editor loading #3429

merged 1 commit into from
Mar 20, 2024

Conversation

uidp
Copy link
Contributor

@uidp uidp commented Mar 19, 2024 •
edited
Loading

Description

H5P-Editor doesn't load with recent changes in the nuxt-client and/or server (dev stage, main).

Links to Tickets or other pull requests

BC-6752

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@uidp uidp changed the title BC-6752 - H5P editor doesn't load under Vue 3 BC-6752 - Fix H5P editor loading Mar 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@uidp uidp merged commit e53aac6 into main Mar 20, 2024
46 of 47 checks passed
@uidp uidp deleted the BC-6752-h5p-vue3-fix branch March 20, 2024 11:04
virgilchiriac pushed a commit that referenced this pull request Mar 21, 2024
@uidp @virgilchiriac
BC-6752 - Fix H5P editor loading (#3429)
547daf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgilchiriac virgilchiriac virgilchiriac left review comments

@odalys-dataport odalys-dataport odalys-dataport approved these changes

Assignees

@uidp uidp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uidp @virgilchiriac @odalys-dataport