Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6809 - modify notification about news publication #3433

Merged
merged 7 commits into from
Apr 8, 2024
Merged

BC-6809 - modify notification about news publication #3433

merged 7 commits into from
Apr 8, 2024

Conversation

WojciechGrancow
Copy link
Contributor

@WojciechGrancow WojciechGrancow commented Apr 2, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6809

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@WojciechGrancow WojciechGrancow self-assigned this Apr 3, 2024
@VikDavydiuk VikDavydiuk self-requested a review April 4, 2024 13:07
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@WojciechGrancow WojciechGrancow merged commit 4294db4 into main Apr 8, 2024
46 of 47 checks passed
@WojciechGrancow WojciechGrancow deleted the BC-6809-refactor-news-publication branch April 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VikDavydiuk VikDavydiuk VikDavydiuk approved these changes

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees

@WojciechGrancow WojciechGrancow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WojciechGrancow @SevenWaysDP @VikDavydiuk