Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7030 - new sidebar #3439

Merged
merged 37 commits into from
Apr 18, 2024
Merged

BC-7030 - new sidebar #3439

merged 37 commits into from
Apr 18, 2024

Conversation

odalys-dataport
Copy link
Contributor

@odalys-dataport odalys-dataport commented Apr 12, 2024 •
edited
Loading

Description

To ensure a consistent layout and create the possibility for broader content width, we want to refactor the legacy sidebar to match the new vue design.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-7030
hpi-schul-cloud/nuxt-client#3193

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@odalys-dataport odalys-dataport self-assigned this Apr 12, 2024
@odalys-dataport odalys-dataport mentioned this pull request Apr 17, 2024
Merged
3 tasks
MartinSchuhmacher
MartinSchuhmacher requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System > GitHub opens in same tab, should be new tab as the others

static/styles/lib/loggedin.scss Outdated Show resolved Hide resolved
static/styles/lib/sidebar.scss Outdated Show resolved Hide resolved
views/lib/loggedin.hbs Outdated Show resolved Hide resolved
MartinSchuhmacher
MartinSchuhmacher reviewed Apr 17, 2024
View reviewed changes
static/scripts/loggedin.js Outdated Show resolved Hide resolved
static/scripts/loggedin.js Outdated Show resolved Hide resolved
static/scripts/loggedin.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odalys-dataport odalys-dataport enabled auto-merge (squash) April 18, 2024 08:20
@odalys-dataport odalys-dataport merged commit 1d463cb into main Apr 18, 2024
46 checks passed
@odalys-dataport odalys-dataport deleted the BC-7030-new-sidebar branch April 18, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchuhmacher MartinSchuhmacher MartinSchuhmacher approved these changes

@uidp uidp Awaiting requested review from uidp

Assignees

@odalys-dataport odalys-dataport

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odalys-dataport @MartinSchuhmacher