Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EW-841 Adding translations for online events announcement #3445

Merged
merged 4 commits into from
Apr 30, 2024
Merged

EW-841 Adding translations for online events announcement #3445

merged 4 commits into from
Apr 30, 2024

Conversation

psachmann
Copy link
Contributor

@psachmann psachmann commented Apr 24, 2024 •
edited
Loading

Description

Adding translations for online events announcement.

Links to Tickets or other pull requests

Deployment

  • Announcement is only active on DBC

Screenshots of UI changes

TBD

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@psachmann psachmann self-assigned this Apr 24, 2024
@psachmann psachmann changed the title EW-841 adding announcement text to the local files EW-841 Adding translations for online events announcement Apr 24, 2024
@psachmann psachmann mentioned this pull request Apr 24, 2024
Merged
1 task
@psachmann psachmann marked this pull request as ready for review April 24, 2024 13:36
@Fshmit Fshmit self-requested a review April 29, 2024 06:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@psachmann psachmann merged commit e9c7feb into main Apr 30, 2024
46 of 47 checks passed
@psachmann psachmann deleted the EW-841 branch April 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fshmit Fshmit Fshmit approved these changes

Assignees

@psachmann psachmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psachmann @Fshmit