Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7541 - Teams: Don't display files info modal when removing a user #3464

Merged
merged 1 commit into from
Jun 21, 2024
Merged

BC-7541 - Teams: Don't display files info modal when removing a user #3464

merged 1 commit into from
Jun 21, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Jun 21, 2024 •
edited by atlldwp
Loading

Description

QUICKFIX fileinfo in team user deletion dialog not necessary anymore, basically rewinding ticket BC-3134

Links to Tickets or other pull requests

BC-7541

Changes

  • removing file info from team user deletion dialog

Screenshots of UI changes

grafik

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher self-assigned this Jun 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MartinSchuhmacher MartinSchuhmacher marked this pull request as ready for review June 21, 2024 12:33
@MartinSchuhmacher MartinSchuhmacher merged commit 8b05e23 into main Jun 21, 2024
46 of 48 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-7541-teams-quickfix branch June 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgilchiriac virgilchiriac virgilchiriac approved these changes

Assignees

@MartinSchuhmacher MartinSchuhmacher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinSchuhmacher @virgilchiriac