Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7804 - prevent logging of headers #3508

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

virgilchiriac
Copy link
Contributor

@virgilchiriac virgilchiriac commented Aug 19, 2024

Description

Links to Tickets or other pull requests

BC-7804

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
Copy link

Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@virgilchiriac virgilchiriac merged commit 129820d into main Aug 26, 2024
72 checks passed
@virgilchiriac virgilchiriac deleted the BC-7804-stop-logging-jwt branch August 26, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants