Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-8415 lti -> ctl in dev config #3541

Merged
merged 2 commits into from
Nov 26, 2024
Merged

BC-8415 lti -> ctl in dev config #3541

merged 2 commits into from
Nov 26, 2024

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Nov 13, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-8415
hpi-schul-cloud/schulcloud-server#5342

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@Loki-Afro Loki-Afro mentioned this pull request Nov 13, 2024
Merged
3 tasks
@Loki-Afro Loki-Afro changed the title BC-8451 lti -> ctl in dev config BC-8415 lti -> ctl in dev config Nov 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Loki-Afro Loki-Afro enabled auto-merge (squash) November 26, 2024 10:59
@Loki-Afro Loki-Afro merged commit e4bd011 into main Nov 26, 2024
68 checks passed
@Loki-Afro Loki-Afro deleted the bc-8451 branch November 26, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchuhmacher MartinSchuhmacher MartinSchuhmacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loki-Afro @MartinSchuhmacher