Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8683 - Wrong plural for news and the time specification #3554

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Jan 13, 2025

Description

Fixing wrong German language times in legacy code (e.g. on dashboard for news and tasks).

Links to Tickets or other pull requests

BC-8683

Changes

Screenshots of UI changes

grafik grafik

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher self-assigned this Jan 13, 2025
Copy link
Member

@Loki-Afro Loki-Afro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you verify that it is broken in the same way in a recent momentjs version?

like the opposite, instead of maintaining the customization, get rid of them as moment js supports a lot of locals https://github.com/moment/moment/tree/18aba135ab927ffe7f868ee09276979bed6993a6/locale

@MartinSchuhmacher
Copy link
Contributor Author

can you verify that it is broken in the same way in a recent momentjs version?

like the opposite, instead of maintaining the customization, get rid of them as moment js supports a lot of locals https://github.com/moment/moment/tree/18aba135ab927ffe7f868ee09276979bed6993a6/locale

I agree, but sadly no, 2.30.1 does not fix that for us. But I do not guarantee, that some of our weird legacy FE and scripting issues there breaks it in the end. But removing more then what I already did just breaks something else there, so I won't go forward with that alternative and in the end adjusted our customization. Thats how I proceed and ended up with that PR :)

@MartinSchuhmacher MartinSchuhmacher enabled auto-merge (squash) January 20, 2025 17:41
@MartinSchuhmacher MartinSchuhmacher merged commit 0590262 into main Jan 20, 2025
70 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-8683-legacy-times branch January 20, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants