This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Feature/sc 3033 reconnect #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianjost
reviewed
Mar 10, 2020
Comment on lines
7
to
+8
| // do some authorization things | ||
| app.channel('anonymous').join(socket.feathers); | ||
| // app.channel('anonymous').join(socket.feathers); |
There was a problem hiding this comment.
der Change ist von @CordlessWool , gebe die Frage weiter :)
There was a problem hiding this comment.
Ich glaube er wollte ein channel für alle haben. Ich würde es erst mal auskommentiert lassen, bis wir es benötigen.
adrianjost
previously approved these changes
Mar 10, 2020
CeEv
suggested changes
Mar 11, 2020
| "redis": "REDIS_URI", | ||
| "redis_key": "REDIS_KEY" | ||
| } | ||
| { |
There was a problem hiding this comment.
Can you set this file to default please.
Comment on lines
7
to
+8
| // do some authorization things | ||
| app.channel('anonymous').join(socket.feathers); | ||
| // app.channel('anonymous').join(socket.feathers); |
There was a problem hiding this comment.
Ich glaube er wollte ein channel für alle haben. Ich würde es erst mal auskommentiert lassen, bis wir es benötigen.
CeEv
reviewed
Sep 24, 2020
| @@ -77,7 +77,7 @@ exports.before = { | |||
| const after = { | |||
| // todo select is better but need more stable implementations | |||
| all: [iff(isProvider('external'), | |||
| filterOutResults('__v', 'createdAt', 'updatedAt')), | |||
There was a problem hiding this comment.
Why change this? @CordlessWool
There was a problem hiding this comment.
Its a long time ago, I could not remember, but its filter out before sending it to the client? For the client the data are not necassery
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkliste
Allgemein
Code Qualität
Tests
Freigabe zum Review
Mehr
Weitere Informationen zur DoD hier im Confluence