Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Filter assignments by course #257

Merged
merged 17 commits into from
Apr 24, 2020
Merged

Conversation

JonasWanke
Copy link
Contributor

Please merge #256 first!
Closes: #145

AssignmentsScreen can now be filtered by course. This also includes quick-filtering by tapping the course-chip on an AssignmentCard and parsing the query string from incoming deep links.

Known issues:

  • I didn't get DraggableScrollableSheet to work inside a ModalBottomSheet, so there is an overflow if the SortFilter sheet is higher than the screen.

Screenshots

SortFilter sheet Active course filter
image image

@JonasWanke JonasWanke added T: feat Type: :tada: New Features M: assignment Module: assignment labels Mar 26, 2020
@unicorn-bot
Copy link

unicorn-bot commented Mar 26, 2020

⚠️ Unicorn Report

⚠️ 3 Warnings

  • refactor(app): cleanup CategoryFilter update

    Co-Authored-By: Marcel Garus [email protected]

  • Merge branch 'master' into issue/145-filter-assignments-by-course
  • Merge branch 'master' into issue/145-filter-assignments-by-course

ℹ️ 1 Info

Generated by 🦄 Unicorn
Report an issue

@github-actions
Copy link

github-actions bot commented Mar 26, 2020

Flutter Analyze found 0 issues ✅

Generated by 🚫 Danger

lib/app/sort_filter/filtering.dart Outdated Show resolved Hide resolved
lib/assignment/widgets/assignments_screen.dart Outdated Show resolved Hide resolved
@janrenz
Copy link
Contributor

janrenz commented Mar 27, 2020

What if the list of courses gets too long?

@JonasWanke
Copy link
Contributor Author

@janrenz The intended effect would be a scrollable sheet (probably using DraggableScrollableSheet), but I didn't get that to work yet (i.e., it currently overflows the screen). We will still merge this PR and look into scrolling soon (#260).

@JonasWanke JonasWanke requested a review from MarcelGarus March 28, 2020 16:31
@JonasWanke JonasWanke merged commit 28fd74a into master Apr 24, 2020
@JonasWanke JonasWanke deleted the issue/145-filter-assignments-by-course branch April 24, 2020 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M: assignment Module: assignment T: feat Type: :tada: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter assignments by course
4 participants