This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Make SortFilterSheet scrollable #351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flutter Analyze found 0 issues ✅Generated by 🚫 Danger |
|
I've updated this PR to use the latest Flutter version and added the missing drag indicator to the bottom sheet. Ideally, the sheet should not be scrollable when there isn't enough content that it is necessary, hence I won't yet add this functionality to black_hole_flutter. |
JonasWanke
suggested changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #260
This should for now fix the issue. However, ideally this change would be made in the
black_hole_flutterpackage so that we could use theFancyBottomSheetfrom there.