BC-6453 - extend error handling in AuthorizationErrorLoggableException

hpi-schul-cloud · Jun 13, 2024 · 1ebdf2e · 1ebdf2e
1 parent 7511741
commit 1ebdf2e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/apps/server/src/infra/authorization-client/authorization-client.adapter.ts b/apps/server/src/infra/authorization-client/authorization-client.adapter.ts
@@ -30,7 +30,7 @@ export class AuthorizationClientAdapter {
 
 			return hasPermission;
 		} catch (error) {
-			throw new AuthorizationErrorLoggableException(error as Error, params);
+			throw new AuthorizationErrorLoggableException(error, params);
 		}
 	}
 

diff --git a/apps/server/src/infra/authorization-client/error/authorization-error.loggable-exception.ts b/apps/server/src/infra/authorization-client/error/authorization-error.loggable-exception.ts
@@ -4,14 +4,15 @@ import { ErrorLogMessage } from '@src/core/logger/types';
 import { AuthorizationBodyParams } from '../authorization-api-client';
 
 export class AuthorizationErrorLoggableException extends ForbiddenException implements Loggable {
-	constructor(private readonly error: Error, private readonly params: AuthorizationBodyParams) {
+	constructor(private readonly error: unknown, private readonly params: AuthorizationBodyParams) {
 		super();
 	}
 
 	getLogMessage(): ErrorLogMessage {
+		const error = this.error instanceof Error ? this.error : new Error(JSON.stringify(this.error));
 		const message: ErrorLogMessage = {
 			type: 'INTERNAL_SERVER_ERROR',
-			error: this.error,
+			error,
 			stack: this.stack,
 			data: {
 				action: this.params.context.action,