change some mocks to Once

hpi-schul-cloud · Jun 13, 2024 · 383d6c4 · 383d6c4
1 parent 3ab920d
commit 383d6c4
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/apps/server/src/modules/board/service/board-common-tool.service.spec.ts b/apps/server/src/modules/board/service/board-common-tool.service.spec.ts
@@ -52,7 +52,7 @@ describe('BoardCommonToolService', () => {
 				{ rootId: '2' } as AnyBoardNode,
 				{ rootId: '1' } as AnyBoardNode,
 			];
-			boardNodeRepo.findByContextExternalToolIds.mockResolvedValue(boardNodes);
+			boardNodeRepo.findByContextExternalToolIds.mockResolvedValueOnce(boardNodes);
 
 			return { contextExternalTools };
 		};
@@ -68,7 +68,7 @@ describe('BoardCommonToolService', () => {
 		it('should return the root node when it is a ColumnBoard', async () => {
 			const boardNode: AnyBoardNode = { id: '1', rootId: '2' } as AnyBoardNode;
 			const rootNode: ColumnBoard = columnBoardFactory.build();
-			boardNodeService.findRoot.mockResolvedValue(rootNode);
+			boardNodeService.findRoot.mockResolvedValueOnce(rootNode);
 
 			const result = await service.findByDescendant(boardNode);
 
@@ -78,7 +78,7 @@ describe('BoardCommonToolService', () => {
 		it('should return the root node when it is a MediaBoard', async () => {
 			const boardNode: AnyBoardNode = { id: '1', rootId: '2' } as AnyBoardNode;
 			const rootNode: MediaBoard = mediaBoardFactory.build();
-			boardNodeService.findRoot.mockResolvedValue(rootNode);
+			boardNodeService.findRoot.mockResolvedValueOnce(rootNode);
 
 			const result = await service.findByDescendant(boardNode);
 
@@ -88,7 +88,7 @@ describe('BoardCommonToolService', () => {
 		it('should throw NotFoundException when root node is not a ColumnBoard or MediaBoard', async () => {
 			const boardNode: AnyBoardNode = { id: '1', rootId: '2' } as AnyBoardNode;
 			const rootNode: AnyBoardNode = { id: '2' } as AnyBoardNode;
-			boardNodeService.findRoot.mockResolvedValue(rootNode);
+			boardNodeService.findRoot.mockResolvedValueOnce(rootNode);
 
 			await expect(service.findByDescendant(boardNode)).rejects.toThrow(NotFoundException);
 		});

diff --git a/apps/server/src/modules/board/service/board-node-permission.service.spec.ts b/apps/server/src/modules/board/service/board-node-permission.service.spec.ts
@@ -74,7 +74,7 @@ describe(BoardNodePermissionService.name, () => {
 
 		it('should call authorization service to checkPermission', async () => {
 			const { anyBoardDo, boardNodeAuthorizable, user } = setup();
-			authorizationService.getUserWithPermissions.mockResolvedValue(user);
+			authorizationService.getUserWithPermissions.mockResolvedValueOnce(user);
 
 			boardNodeAuthorizableService.getBoardAuthorizable.mockResolvedValueOnce(boardNodeAuthorizable);
 

diff --git a/apps/server/src/modules/board/service/column-board.service.spec.ts b/apps/server/src/modules/board/service/column-board.service.spec.ts
@@ -68,7 +68,7 @@ describe('ColumnBoardService', () => {
 
 	it('should find ColumnBoards by external reference', async () => {
 		const columnBoard = columnBoardFactory.build();
-		repo.findByExternalReference.mockResolvedValue([columnBoard]);
+		repo.findByExternalReference.mockResolvedValueOnce([columnBoard]);
 		const reference: BoardExternalReference = {
 			type: BoardExternalReferenceType.Course,
 			id: '1',
@@ -90,7 +90,7 @@ describe('ColumnBoardService', () => {
 
 	it('should delete ColumnBoards by course id', async () => {
 		const columnBoard = columnBoardFactory.build();
-		repo.findByExternalReference.mockResolvedValue([columnBoard]);
+		repo.findByExternalReference.mockResolvedValueOnce([columnBoard]);
 		const reference: BoardExternalReference = {
 			type: BoardExternalReferenceType.Course,
 			id: '1',
@@ -104,7 +104,7 @@ describe('ColumnBoardService', () => {
 
 	it('should copy ColumnBoard', async () => {
 		const copyStatus: CopyStatus = { status: CopyStatusEnum.SUCCESS, type: CopyElementType.COLUMNBOARD };
-		columnBoardCopyService.copyColumnBoard.mockResolvedValue(copyStatus);
+		columnBoardCopyService.copyColumnBoard.mockResolvedValueOnce(copyStatus);
 		const result = await service.copyColumnBoard({
 			originalColumnBoardId: '1',
 			destinationExternalReference: {
@@ -121,7 +121,7 @@ describe('ColumnBoardService', () => {
 		const idMap = new Map<EntityId, EntityId>();
 		idMap.set('1', '2');
 		const columnBoard = columnBoardFactory.build();
-		columnBoardLinkService.swapLinkedIds.mockResolvedValue(columnBoard);
+		columnBoardLinkService.swapLinkedIds.mockResolvedValueOnce(columnBoard);
 
 		const result = await service.swapLinkedIds('1', idMap);
 

diff --git a/apps/server/src/modules/board/service/media-board/media-available-line.service.spec.ts b/apps/server/src/modules/board/service/media-board/media-available-line.service.spec.ts
@@ -96,7 +96,7 @@ describe(MediaAvailableLineService.name, () => {
 				});
 				const board: MediaBoard = mediaBoardFactory.build({ children: [mediaExternalToolElement] });
 
-				schoolExternalToolService.findSchoolExternalTools.mockResolvedValue([
+				schoolExternalToolService.findSchoolExternalTools.mockResolvedValueOnce([
 					schoolExternalTool,
 					usedSchoolExternalTool,
 				]);
@@ -168,7 +168,7 @@ describe(MediaAvailableLineService.name, () => {
 				});
 				mediaBoardService.findMediaElements.mockReturnValueOnce([mediaExternalToolElement]);
 
-				schoolExternalToolService.findSchoolExternalTools.mockResolvedValue([
+				schoolExternalToolService.findSchoolExternalTools.mockResolvedValueOnce([
 					schoolExternalTool,
 					usedSchoolExternalTool,
 				]);

diff --git a/apps/server/src/modules/board/service/media-board/media-board.service.spec.ts b/apps/server/src/modules/board/service/media-board/media-board.service.spec.ts
@@ -72,14 +72,14 @@ describe('MediaBoardService', () => {
 				const mediaLine = mediaLineFactory.build({ children: [mediaExternalToolElement] });
 				const mediaBoard = mediaBoardFactory.build({ children: [mediaLine] });
 
-				contextExternalToolService.findContextExternalTools.mockResolvedValue([]);
+				contextExternalToolService.findContextExternalTools.mockResolvedValueOnce([]);
 
 				return { schoolExternalTool, mediaBoard };
 			};
 			it('should call findContextExternalTools', async () => {
 				const schoolExternalTool = schoolExternalToolFactory.build();
 				const mediaBoard = mediaBoardFactory.build();
-				contextExternalToolService.findContextExternalTools.mockResolvedValue([]);
+				contextExternalToolService.findContextExternalTools.mockResolvedValueOnce([]);
 				await service.checkElementExists(mediaBoard, schoolExternalTool);
 				expect(contextExternalToolService.findContextExternalTools).toHaveBeenCalledWith({
 					schoolToolRef: { schoolToolId: schoolExternalTool.id },
@@ -102,7 +102,7 @@ describe('MediaBoardService', () => {
 				const mediaLine = mediaLineFactory.build({ children: [mediaExternalToolElement] });
 				const mediaBoard = mediaBoardFactory.build({ children: [mediaLine] });
 
-				contextExternalToolService.findContextExternalTools.mockResolvedValue([contextExternalTool]);
+				contextExternalToolService.findContextExternalTools.mockResolvedValueOnce([contextExternalTool]);
 
 				return { schoolExternalTool, mediaBoard };
 			};

diff --git a/apps/server/src/modules/learnroom/repo/mikro-orm/column-board-node.repo.spec.ts b/apps/server/src/modules/learnroom/repo/mikro-orm/column-board-node.repo.spec.ts
@@ -36,7 +36,7 @@ describe('ColumnBoardNodeRepo', () => {
 	describe('findById', () => {
 		const setup = () => {
 			const columnBoardNode = columnBoardFactory.build();
-			em.findOneOrFail.mockResolvedValue(columnBoardNode);
+			em.findOneOrFail.mockResolvedValueOnce(columnBoardNode);
 
 			return { columnBoardNode };
 		};