fix oauth service and test

apps/server/src/modules/authentication/errors/index.ts

@@ -1,4 +1,3 @@
 export * from './brute-force.error';
 export * from './ldap-connection.error';
-export * from './school-in-migration.error';
 export * from './unauthorized.loggable-exception';

apps/server/src/modules/authentication/loggable/index.ts

@@ -0,0 +1 @@
+export * from './school-in-migration.loggable-exception';

apps/server/src/modules/authentication/errors/school-in-migration.error.ts → apps/server/src/modules/authentication/loggable/school-in-migration.loggable-exception.ts

@@ -1,16 +1,23 @@
 import { HttpStatus } from '@nestjs/common';
 import { BusinessError } from '@shared/common';
+import { ErrorLogMessage, Loggable } from '@src/core/logger';
 
-export class SchoolInMigrationError extends BusinessError {
-	constructor(details?: Record<string, unknown>) {
+export class SchoolInMigrationLoggableException extends BusinessError implements Loggable {
+	constructor() {
 		super(
 			{
 				type: 'SCHOOL_IN_MIGRATION',
 				title: 'Login failed because school is in migration',
 				defaultMessage: 'Login failed because creation of user is not possible during migration',
 			},
-			HttpStatus.UNAUTHORIZED,
-			details
+			HttpStatus.UNAUTHORIZED
 		);
 	}
+
+	getLogMessage(): ErrorLogMessage {
+		return {
+			type: this.type,
+			stack: this.stack,
+		};
+	}
 }

apps/server/src/modules/authentication/strategy/oauth2.strategy.spec.ts

@@ -1,15 +1,15 @@
 import { createMock, DeepMocked } from '@golevelup/ts-jest';
+import { AccountService } from '@modules/account/services/account.service';
+import { AccountDto } from '@modules/account/services/dto';
+import { OAuthTokenDto } from '@modules/oauth';
+import { OAuthService } from '@modules/oauth/service/oauth.service';
 import { UnauthorizedException } from '@nestjs/common';
 import { Test, TestingModule } from '@nestjs/testing';
 import { EntityId, RoleName } from '@shared/domain';
 import { UserDO } from '@shared/domain/domainobject/user.do';
 import { userDoFactory } from '@shared/testing';
-import { AccountService } from '@modules/account/services/account.service';
-import { AccountDto } from '@modules/account/services/dto';
-import { OAuthTokenDto } from '@modules/oauth';
-import { OAuthService } from '@modules/oauth/service/oauth.service';
-import { SchoolInMigrationError } from '../errors/school-in-migration.error';
 import { ICurrentUser, OauthCurrentUser } from '../interface';
+import { SchoolInMigrationLoggableException } from '../loggable';
 import { Oauth2Strategy } from './oauth2.strategy';
 
 describe('Oauth2Strategy', () => {
@@ -68,7 +68,7 @@ describe('Oauth2Strategy', () => {
 						refreshToken: 'refreshToken',
 					})
 				);
-				oauthService.provisionUser.mockResolvedValue({ user, redirect: '' });
+				oauthService.provisionUser.mockResolvedValue(user);
 				accountService.findByUserId.mockResolvedValue(account);
 
 				return { systemId, user, account, idToken };
@@ -102,7 +102,7 @@ describe('Oauth2Strategy', () => {
 						refreshToken: 'refreshToken',
 					})
 				);
-				oauthService.provisionUser.mockResolvedValue({ user: undefined, redirect: '' });
+				oauthService.provisionUser.mockResolvedValue(null);
 			};
 
 			it('should throw a SchoolInMigrationError', async () => {
@@ -111,7 +111,7 @@ describe('Oauth2Strategy', () => {
 				const func = async () =>
 					strategy.validate({ body: { code: 'code', redirectUri: 'redirectUri', systemId: 'systemId' } });
 
-				await expect(func).rejects.toThrow(new SchoolInMigrationError());
+				await expect(func).rejects.toThrow(new SchoolInMigrationLoggableException());
 			});
 		});
 
@@ -126,7 +126,7 @@ describe('Oauth2Strategy', () => {
 						refreshToken: 'refreshToken',
 					})
 				);
-				oauthService.provisionUser.mockResolvedValue({ user, redirect: '' });
+				oauthService.provisionUser.mockResolvedValue(user);
 				accountService.findByUserId.mockResolvedValue(null);
 			};
 

apps/server/src/modules/authentication/strategy/oauth2.strategy.ts

@@ -1,14 +1,14 @@
-import { Injectable, UnauthorizedException } from '@nestjs/common';
-import { PassportStrategy } from '@nestjs/passport';
-import { UserDO } from '@shared/domain/domainobject/user.do';
 import { AccountService } from '@modules/account/services/account.service';
 import { AccountDto } from '@modules/account/services/dto';
 import { OAuthTokenDto } from '@modules/oauth';
 import { OAuthService } from '@modules/oauth/service/oauth.service';
+import { Injectable, UnauthorizedException } from '@nestjs/common';
+import { PassportStrategy } from '@nestjs/passport';
+import { UserDO } from '@shared/domain/domainobject/user.do';
 import { Strategy } from 'passport-custom';
 import { Oauth2AuthorizationBodyParams } from '../controllers/dto';
-import { SchoolInMigrationError } from '../errors/school-in-migration.error';
 import { ICurrentUser, OauthCurrentUser } from '../interface';
+import { SchoolInMigrationLoggableException } from '../loggable';
 import { CurrentUserMapper } from '../mapper';
 
 @Injectable()
@@ -22,14 +22,10 @@ export class Oauth2Strategy extends PassportStrategy(Strategy, 'oauth2') {
 
 		const tokenDto: OAuthTokenDto = await this.oauthService.authenticateUser(systemId, redirectUri, code);
 
-		const { user }: { user?: UserDO; redirect: string } = await this.oauthService.provisionUser(
-			systemId,
-			tokenDto.idToken,
-			tokenDto.accessToken
-		);
+		const user: UserDO | null = await this.oauthService.provisionUser(systemId, tokenDto.idToken, tokenDto.accessToken);
 
 		if (!user || !user.id) {
-			throw new SchoolInMigrationError();
+			throw new SchoolInMigrationLoggableException();
 		}
 
 		const account: AccountDto | null = await this.accountService.findByUserId(user.id);

apps/server/src/modules/oauth/controller/dto/authorization.params.ts

@@ -1,9 +1,6 @@
 import { IsEnum, IsNotEmpty, IsOptional, IsString } from 'class-validator';
 import { SSOAuthenticationError } from '../../interface/sso-authentication-error.enum';
 
-/**
- * @deprecated
- */
 export class AuthorizationParams {
 	@IsOptional()
 	@IsString()

apps/server/src/modules/oauth/controller/dto/index.ts

@@ -1,4 +1 @@
 export * from './authorization.params';
-export * from './system-id.params';
-export * from './sso-login.query';
-export * from './user-migration.response';