fix no implicit public part3

hpi-schul-cloud · Dec 13, 2024 · 4d529e5 · 4d529e5
1 parent 7ee84ca
commit 4d529e5
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 14 deletions.
diff --git a/apps/server/src/modules/account/domain/update-account.ts b/apps/server/src/modules/account/domain/update-account.ts
@@ -1,9 +1,9 @@
 export class UpdateAccount {
-	username?: string;
+	public username?: string;
 
-	password?: string;
+	public password?: string;
 
-	activated?: boolean;
+	public activated?: boolean;
 
 	constructor(props: UpdateAccount) {
 		this.username = props.username;

diff --git a/apps/server/src/modules/account/domain/update-my-account.ts b/apps/server/src/modules/account/domain/update-my-account.ts
@@ -1,13 +1,13 @@
 export class UpdateMyAccount {
-	passwordOld!: string;
+	public passwordOld!: string;
 
-	passwordNew?: string;
+	public passwordNew?: string;
 
-	email?: string;
+	public email?: string;
 
-	firstName?: string;
+	public firstName?: string;
 
-	lastName?: string;
+	public lastName?: string;
 
 	constructor(props: UpdateMyAccount) {
 		this.passwordOld = props.passwordOld;

diff --git a/apps/server/src/modules/account/repo/micro-orm/account.repo.integration.spec.ts b/apps/server/src/modules/account/repo/micro-orm/account.repo.integration.spec.ts
@@ -36,6 +36,26 @@ describe('account repo', () => {
 		expect(repo.entityName).toBe(AccountEntity);
 	});
 
+	describe('mapDOToEntityProperties', () => {
+		describe('When an account is given', () => {
+			it('should map the account to an entity', () => {
+				const account = accountDoFactory.build();
+				const entityProps = AccountDoToEntityMapper.mapToEntity(account);
+
+				expect(entityProps).toEqual(expect.objectContaining(account.getProps()));
+			});
+		});
+
+		describe('When an account with partial props is given', () => {
+			it('should map the account to an entity', () => {
+				const account = accountDoFactory.build({ id: new ObjectId().toHexString(), username: 'John Doe' });
+				const entityProps = AccountDoToEntityMapper.mapToEntity(account);
+
+				expect(entityProps).toEqual(expect.objectContaining(account.getProps()));
+			});
+		});
+	});
+
 	describe('save', () => {
 		describe('When an account is given', () => {
 			it('should save an account', async () => {

diff --git a/apps/server/src/modules/account/repo/micro-orm/mapper/account-entity-to-do.mapper.ts b/apps/server/src/modules/account/repo/micro-orm/mapper/account-entity-to-do.mapper.ts
@@ -3,7 +3,7 @@ import { Account } from '../../../domain/account';
 import { AccountEntity } from '../../../domain/entity/account.entity';
 
 export class AccountEntityToDoMapper {
-	static mapToDo(account: AccountEntity): Account {
+	public static mapToDo(account: AccountEntity): Account {
 		return new Account({
 			id: account.id,
 			createdAt: account.createdAt,
@@ -22,13 +22,13 @@ export class AccountEntityToDoMapper {
 		});
 	}
 
-	static mapCountedEntities(accountEntities: Counted<AccountEntity[]>): Counted<Account[]> {
+	public static mapCountedEntities(accountEntities: Counted<AccountEntity[]>): Counted<Account[]> {
 		const foundAccounts = accountEntities[0];
 		const accountDtos: Account[] = AccountEntityToDoMapper.mapEntitiesToDos(foundAccounts);
 		return [accountDtos, accountEntities[1]];
 	}
 
-	static mapEntitiesToDos(accounts: AccountEntity[]): Account[] {
+	public static mapEntitiesToDos(accounts: AccountEntity[]): Account[] {
 		return accounts.map((accountEntity) => AccountEntityToDoMapper.mapToDo(accountEntity));
 	}
 }
diff --git a/apps/server/src/modules/account/repo/micro-orm/mapper/account-idm-to-do.mapper.abstract.ts b/apps/server/src/modules/account/repo/micro-orm/mapper/account-idm-to-do.mapper.abstract.ts
@@ -4,5 +4,5 @@ import { Account } from '../../../domain/account';
 
 @Injectable()
 export abstract class AccountIdmToDoMapper {
-	abstract mapToDo(account: IdmAccount): Account;
+	public abstract mapToDo(account: IdmAccount): Account;
 }
diff --git a/apps/server/src/modules/account/repo/micro-orm/mapper/account-idm-to-do.mapper.db.ts b/apps/server/src/modules/account/repo/micro-orm/mapper/account-idm-to-do.mapper.db.ts
@@ -3,7 +3,7 @@ import { Account } from '../../../domain/account';
 import { AccountIdmToDoMapper } from './account-idm-to-do.mapper.abstract';
 
 export class AccountIdmToDoMapperDb extends AccountIdmToDoMapper {
-	mapToDo(account: IdmAccount): Account {
+	public mapToDo(account: IdmAccount): Account {
 		const createdDate = account.createdDate ? account.createdDate : new Date();
 		return new Account({
 			id: account.attDbcAccountId ?? '',

diff --git a/apps/server/src/modules/account/repo/micro-orm/mapper/account-idm-to-do.mapper.idm.ts b/apps/server/src/modules/account/repo/micro-orm/mapper/account-idm-to-do.mapper.idm.ts
@@ -3,7 +3,7 @@ import { Account } from '../../../domain/account';
 import { AccountIdmToDoMapper } from './account-idm-to-do.mapper.abstract';
 
 export class AccountIdmToDoMapperIdm extends AccountIdmToDoMapper {
-	mapToDo(account: IdmAccount): Account {
+	public mapToDo(account: IdmAccount): Account {
 		const createdDate = account.createdDate ? account.createdDate : new Date();
 		return new Account({
 			id: account.id,