N21-2191 fix

hpi-schul-cloud · Oct 9, 2024 · 4e3f00b · 4e3f00b
1 parent 0d5ce48
commit 4e3f00b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/apps/server/src/modules/tool/external-tool/uc/external-tool.uc.ts b/apps/server/src/modules/tool/external-tool/uc/external-tool.uc.ts
@@ -135,10 +135,13 @@ export class ExternalToolUc {
 		// Use secrets from existing config
 		const updatedConfigProps: ExternalToolConfig = { ...currentExternalTool.config, ...externalToolUpdateProps.config };
 
+		const { isLti11Config } = ExternalTool;
+
 		if (
-			ExternalTool.isLti11Config(updatedConfigProps) &&
-			ExternalTool.isLti11Config(currentExternalTool.config) &&
-			updatedConfigProps.secret !== currentExternalTool.config.secret
+			(isLti11Config(updatedConfigProps) &&
+				isLti11Config(currentExternalTool.config) &&
+				updatedConfigProps.secret !== currentExternalTool.config.secret) ||
+			(!isLti11Config(currentExternalTool.config) && isLti11Config(updatedConfigProps))
 		) {
 			updatedConfigProps.secret = this.encryptionService.encrypt(updatedConfigProps.secret);
 		}