test coverage

apps/server/src/infra/sync/media-licenses/service/vidis-sync.service.spec.ts

@@ -20,7 +20,7 @@ import { HttpService } from '@nestjs/axios';
 import { createMock, DeepMocked } from '@golevelup/ts-jest';
 import { of, throwError } from 'rxjs';
 import { AxiosError, AxiosRequestConfig, AxiosResponse } from 'axios';
-import { VidisResponse } from '../response';
+import { VidisItemResponse, VidisResponse } from '../response';
 import { vidisResponseFactory, vidisItemResponseFactory } from '../testing';
 import { VidisSyncService } from './vidis-sync.service';
 
@@ -134,8 +134,15 @@ describe(VidisSyncService.name, () => {
 				const setup = () => {
 					const mediaSource = mediaSourceFactory.withBasicAuthConfig().build();
 					const basicAuthConfig = mediaSource.basicAuthConfig as MediaSourceBasicAuthConfig;
+
+					const vidisItemResponse: VidisItemResponse[] = vidisItemResponseFactory.buildList(3);
+					vidisItemResponse[0].offerTitle = 'Other Title';
+
+					const vidisResponse: VidisResponse = vidisResponseFactory.build();
+					vidisResponse.items = vidisItemResponse;
+
 					const axiosResponse: AxiosResponse<VidisResponse> = axiosResponseFactory.build({
-						data: vidisResponseFactory.build(),
+						data: vidisResponse,
 					});
 
 					httpService.get.mockReturnValueOnce(of(axiosResponse));

apps/server/src/infra/sync/media-licenses/service/vidis-sync.service.ts

@@ -71,9 +71,9 @@ export class VidisSyncService {
 					if (!school) {
 						this.logger.info(new SchoolForSchoolMediaLicenseSyncNotFoundLoggable(schoolNumber));
 					} else {
-						const isExistingLicense: boolean = existingLicenses.some((license: MediaSchoolLicense): boolean => {
-							return license.schoolId === school.id;
-						});
+						const isExistingLicense = !!existingLicenses.find(
+							(license: MediaSchoolLicense): boolean => license.schoolId === school.id
+						);
 						if (!isExistingLicense) {
 							const newLicense: MediaSchoolLicense = new MediaSchoolLicense({
 								id: new ObjectId().toHexString(),

apps/server/src/modules/school-license/domain/index.ts

@@ -1,2 +1,2 @@
-export { MediaSchoolLicense } from './media-school-license';
+export { MediaSchoolLicense, MediaSchoolLicenseProps } from './media-school-license';
 export { SchoolLicense } from './school-license';

apps/server/src/modules/school-license/entity/index.ts

@@ -1,2 +1,2 @@
-export { MediaSchoolLicenseEntity } from './media-school-license.entity';
+export { MediaSchoolLicenseEntity, MediaSchoolLicenseEntityProps } from './media-school-license.entity';
 export { SchoolLicenseEntity } from './school-license.entity';

apps/server/src/modules/school-license/repo/mapper/media-school-license.entity.mapper.spec.ts

@@ -27,7 +27,7 @@ describe(MediaSchoolLicenseEntityMapper.name, () => {
 			it('should return the domain object of the entity', () => {
 				const { mediaSchoolLicenseEntity, expectedDomainObject } = setup();
 
-				const domainObject: MediaSchoolLicense = MediaSchoolLicenseEntityMapper.mapEntityToDo(mediaSchoolLicenseEntity);
+				const domainObject: MediaSchoolLicense = MediaSchoolLicenseEntityMapper.mapEntityToDO(mediaSchoolLicenseEntity);
 
 				expect(domainObject).toEqual(expectedDomainObject);
 			});

apps/server/src/modules/school-license/repo/mapper/media-school-license.entity.mapper.ts

@@ -9,7 +9,7 @@ import { MediaSchoolLicense } from '../../domain';
 import { SchoolLicenseType } from '../../enum';
 
 export class MediaSchoolLicenseEntityMapper {
-	public static mapEntityToDo(entity: MediaSchoolLicenseEntity): MediaSchoolLicense {
+	public static mapEntityToDO(entity: MediaSchoolLicenseEntity): MediaSchoolLicense {
 		let mediaSource: MediaSource | undefined;
 
 		if (entity.mediaSource) {

apps/server/src/modules/school-license/repo/mikro-orm/media-school-license.repo.integration.spec.ts

@@ -52,7 +52,7 @@ describe(MediaSchoolLicenseMikroOrmRepo.name, () => {
 				em.clear();
 
 				const expectedDOs: MediaSchoolLicense[] = mediaSchoolLicenses.map(
-					(entity: MediaSchoolLicenseEntity): MediaSchoolLicense => MediaSchoolLicenseEntityMapper.mapEntityToDo(entity)
+					(entity: MediaSchoolLicenseEntity): MediaSchoolLicense => MediaSchoolLicenseEntityMapper.mapEntityToDO(entity)
 				);
 
 				return {

apps/server/src/modules/school-license/repo/mikro-orm/media-school-license.repo.ts

@@ -31,7 +31,7 @@ export class MediaSchoolLicenseMikroOrmRepo
 	}
 
 	private mapEntityToDomainObject(entity: MediaSchoolLicenseEntity): MediaSchoolLicense {
-		const schoolLicense: MediaSchoolLicense = MediaSchoolLicenseEntityMapper.mapEntityToDo(entity);
+		const schoolLicense: MediaSchoolLicense = MediaSchoolLicenseEntityMapper.mapEntityToDO(entity);
 
 		return schoolLicense;
 	}

apps/server/src/modules/school-license/testing/media-school-license-entity.factory.ts

@@ -1,14 +1,15 @@
 import { BaseFactory, schoolEntityFactory } from '@shared/testing';
-import { mediaSourceEntityFactory } from '@src/modules/media-source/testing/media-source-entity.factory';
-import { MediaSchoolLicenseEntity } from '../entity';
+import { mediaSourceEntityFactory } from '@modules/media-source/testing';
+import { ObjectId } from '@mikro-orm/mongodb';
+import { MediaSchoolLicenseEntity, MediaSchoolLicenseEntityProps } from '../entity';
 import { SchoolLicenseType } from '../enum';
-import { MediaSchoolLicenseEntityProps } from '../entity/media-school-license.entity';
 
 export const mediaSchoolLicenseEntityFactory = BaseFactory.define<
 	MediaSchoolLicenseEntity,
 	MediaSchoolLicenseEntityProps
 >(MediaSchoolLicenseEntity, ({ sequence }) => {
 	return {
+		id: new ObjectId().toHexString(),
 		school: schoolEntityFactory.build(),
 		type: SchoolLicenseType.MEDIA_LICENSE,
 		mediumId: `medium-${sequence}`,

apps/server/src/modules/school-license/testing/media-school-license.factory.ts

@@ -1,8 +1,7 @@
 import { ObjectId } from '@mikro-orm/mongodb';
 import { BaseFactory } from '@shared/testing';
-import { mediaSourceFactory } from '@src/modules/media-source/testing/media-source.factory';
-import { MediaSchoolLicense } from '../domain';
-import { MediaSchoolLicenseProps } from '../domain/media-school-license';
+import { mediaSourceFactory } from '@modules/media-source/testing';
+import { MediaSchoolLicense, MediaSchoolLicenseProps } from '../domain';
 import { SchoolLicenseType } from '../enum';
 
 export const mediaSchoolLicenseFactory = BaseFactory.define<MediaSchoolLicense, MediaSchoolLicenseProps>(