N21-1207 show group members

apps/server/src/modules/authorization/rule-manager.spec.ts

@@ -13,6 +13,7 @@ import {
 	TaskRule,
 	TeamRule,
 	UserRule,
+	GroupRule,
 } from '@shared/domain/rules';
 import { UserLoginMigrationRule } from '@shared/domain/rules/user-login-migration.rule';
 import { courseFactory, setupEntities, userFactory } from '@shared/testing';
@@ -33,6 +34,7 @@ describe('RuleManager', () => {
 	let boardDoRule: DeepMocked<BoardDoRule>;
 	let contextExternalToolRule: DeepMocked<ContextExternalToolRule>;
 	let userLoginMigrationRule: DeepMocked<UserLoginMigrationRule>;
+	let groupRule: DeepMocked<GroupRule>;
 
 	beforeAll(async () => {
 		await setupEntities();
@@ -52,6 +54,7 @@ describe('RuleManager', () => {
 				{ provide: BoardDoRule, useValue: createMock<BoardDoRule>() },
 				{ provide: ContextExternalToolRule, useValue: createMock<ContextExternalToolRule>() },
 				{ provide: UserLoginMigrationRule, useValue: createMock<UserLoginMigrationRule>() },
+				{ provide: GroupRule, useValue: createMock<GroupRule>() },
 			],
 		}).compile();
 
@@ -68,6 +71,7 @@ describe('RuleManager', () => {
 		boardDoRule = await module.get(BoardDoRule);
 		contextExternalToolRule = await module.get(ContextExternalToolRule);
 		userLoginMigrationRule = await module.get(UserLoginMigrationRule);
+		groupRule = await module.get(GroupRule);
 	});
 
 	afterEach(() => {
@@ -98,6 +102,7 @@ describe('RuleManager', () => {
 				boardDoRule.isApplicable.mockReturnValueOnce(false);
 				contextExternalToolRule.isApplicable.mockReturnValueOnce(false);
 				userLoginMigrationRule.isApplicable.mockReturnValueOnce(false);
+				groupRule.isApplicable.mockReturnValueOnce(false);
 
 				return { user, object, context };
 			};
@@ -119,6 +124,7 @@ describe('RuleManager', () => {
 				expect(boardDoRule.isApplicable).toBeCalled();
 				expect(contextExternalToolRule.isApplicable).toBeCalled();
 				expect(userLoginMigrationRule.isApplicable).toBeCalled();
+				expect(groupRule.isApplicable).toBeCalled();
 			});
 
 			it('should return CourseRule', () => {
@@ -148,6 +154,7 @@ describe('RuleManager', () => {
 				boardDoRule.isApplicable.mockReturnValueOnce(false);
 				contextExternalToolRule.isApplicable.mockReturnValueOnce(false);
 				userLoginMigrationRule.isApplicable.mockReturnValueOnce(false);
+				groupRule.isApplicable.mockReturnValueOnce(false);
 
 				return { user, object, context };
 			};
@@ -177,6 +184,7 @@ describe('RuleManager', () => {
 				boardDoRule.isApplicable.mockReturnValueOnce(false);
 				contextExternalToolRule.isApplicable.mockReturnValueOnce(false);
 				userLoginMigrationRule.isApplicable.mockReturnValueOnce(false);
+				groupRule.isApplicable.mockReturnValueOnce(false);
 
 				return { user, object, context };
 			};

apps/server/src/modules/authorization/rule-manager.ts

@@ -12,6 +12,7 @@ import {
 	TaskRule,
 	TeamRule,
 	UserRule,
+	GroupRule,
 } from '@shared/domain/rules';
 import { ContextExternalToolRule } from '@shared/domain/rules/context-external-tool.rule';
 import { UserLoginMigrationRule } from '@shared/domain/rules/user-login-migration.rule';
@@ -33,7 +34,8 @@ export class RuleManager {
 		private readonly schoolExternalToolRule: SchoolExternalToolRule,
 		private readonly boardDoRule: BoardDoRule,
 		private readonly contextExternalToolRule: ContextExternalToolRule,
-		private readonly userLoginMigrationRule: UserLoginMigrationRule
+		private readonly userLoginMigrationRule: UserLoginMigrationRule,
+		private readonly groupRule: GroupRule
 	) {
 		this.rules = [
 			this.courseRule,
@@ -48,6 +50,7 @@ export class RuleManager {
 			this.boardDoRule,
 			this.contextExternalToolRule,
 			this.userLoginMigrationRule,
+			this.groupRule,
 		];
 	}
 

apps/server/src/modules/group/controller/api-test/group.api.spec.ts

@@ -15,6 +15,7 @@ import {
 import { ClassEntity } from '@src/modules/class/entity';
 import { classEntityFactory } from '@src/modules/class/entity/testing/factory/class.entity.factory';
 import { ServerTestModule } from '@src/modules/server';
+import { ObjectId } from 'bson';
 import { GroupEntity, GroupEntityTypes } from '../../entity';
 import { ClassRootType } from '../../uc/dto/class-root-type';
 import { ClassInfoSearchListResponse, ClassSortBy } from '../dto';
@@ -41,7 +42,7 @@ describe('Group (API)', () => {
 		await app.close();
 	});
 
-	describe('findClassesForSchool', () => {
+	describe('[GET] /groups/class', () => {
 		describe('when an admin requests a list of classes', () => {
 			const setup = async () => {
 				const school: SchoolEntity = schoolFactory.buildWithId();
@@ -157,4 +158,119 @@ describe('Group (API)', () => {
 			});
 		});
 	});
+
+	describe('[GET] /groups/:groupId', () => {
+		describe('when authorized user requests a group', () => {
+			describe('when group exists', () => {
+				const setup = async () => {
+					const school: SchoolEntity = schoolFactory.buildWithId();
+					const { teacherAccount, teacherUser } = UserAndAccountTestFactory.buildTeacher({ school });
+
+					const group: GroupEntity = groupEntityFactory.buildWithId({
+						users: [
+							{
+								user: teacherUser,
+								role: teacherUser.roles[0],
+							},
+						],
+						organization: school,
+					});
+
+					await em.persistAndFlush([teacherAccount, teacherUser, group]);
+					em.clear();
+
+					const loggedInClient = await testApiClient.login(teacherAccount);
+
+					return {
+						loggedInClient,
+						group,
+						teacherUser,
+					};
+				};
+
+				it('should return the group', async () => {
+					const { loggedInClient, group, teacherUser } = await setup();
+
+					const response = await loggedInClient.get(`${group.id}`);
+
+					expect(response.status).toEqual(HttpStatus.OK);
+					expect(response.body).toEqual({
+						id: group.id,
+						name: group.name,
+						type: group.type,
+						users: [
+							{
+								id: teacherUser.id,
+								firstName: teacherUser.firstName,
+								lastName: teacherUser.lastName,
+								role: teacherUser.roles[0].name,
+							},
+						],
+						externalSource: {
+							externalId: group.externalSource?.externalId,
+							systemId: group.externalSource?.system.id,
+						},
+					});
+				});
+			});
+
+			describe('when group does not exist', () => {
+				const setup = async () => {
+					const { teacherAccount, teacherUser } = UserAndAccountTestFactory.buildTeacher();
+
+					await em.persistAndFlush([teacherAccount, teacherUser]);
+					em.clear();
+
+					const loggedInClient = await testApiClient.login(teacherAccount);
+
+					return {
+						loggedInClient,
+					};
+				};
+
+				it('should return not found', async () => {
+					const { loggedInClient } = await setup();
+
+					const response = await loggedInClient.get(`${new ObjectId().toHexString()}`);
+
+					expect(response.status).toEqual(HttpStatus.NOT_FOUND);
+					expect(response.body).toEqual({
+						code: HttpStatus.NOT_FOUND,
+						message: 'Not Found',
+						title: 'Not Found',
+						type: 'NOT_FOUND',
+					});
+				});
+			});
+		});
+
+		describe('when unauthorized user requests a group', () => {
+			const setup = async () => {
+				const { studentAccount, studentUser } = UserAndAccountTestFactory.buildStudent();
+
+				const group: GroupEntity = groupEntityFactory.buildWithId();
+
+				await em.persistAndFlush([studentAccount, studentUser, group]);
+				em.clear();
+
+				return {
+					groupId: group.id,
+				};
+			};
+
+			it('should return unauthorized', async () => {
+				const { groupId } = await setup();
+
+				const response = await testApiClient.get(`${groupId}`);
+
+				expect(response.status).toEqual(HttpStatus.UNAUTHORIZED);
+				expect(response.body).toEqual({
+					code: HttpStatus.UNAUTHORIZED,
+					message: 'Unauthorized',
+					title: 'Unauthorized',
+					type: 'UNAUTHORIZED',
+				});
+			});
+		});
+	});
 });

apps/server/src/modules/group/controller/dto/request/group-id-params.ts

@@ -0,0 +1,8 @@
+import { ApiProperty } from '@nestjs/swagger';
+import { IsMongoId } from 'class-validator';
+
+export class GroupIdParams {
+	@IsMongoId()
+	@ApiProperty({ nullable: false, required: true })
+	groupId!: string;
+}

apps/server/src/modules/group/controller/dto/request/index.ts

@@ -1 +1,2 @@
 export * from './class-sort-params';
+export * from './group-id-params';

apps/server/src/modules/group/controller/dto/response/external-source.response.ts

@@ -0,0 +1,14 @@
+import { ApiProperty } from '@nestjs/swagger';
+
+export class ExternalSourceResponse {
+	@ApiProperty()
+	externalId: string;
+
+	@ApiProperty()
+	systemId: string;
+
+	constructor(props: ExternalSourceResponse) {
+		this.externalId = props.externalId;
+		this.systemId = props.systemId;
+	}
+}

apps/server/src/modules/group/controller/dto/response/group-type.response.ts

@@ -0,0 +1,3 @@
+export enum GroupTypeResponse {
+	CLASS = 'class',
+}

apps/server/src/modules/group/controller/dto/response/group-user.response.ts

@@ -0,0 +1,23 @@
+import { ApiProperty } from '@nestjs/swagger';
+import { RoleName } from '@shared/domain';
+
+export class GroupUserResponse {
+	@ApiProperty()
+	id: string;
+
+	@ApiProperty()
+	firstName: string;
+
+	@ApiProperty()
+	lastName: string;
+
+	@ApiProperty()
+	role: RoleName;
+
+	constructor(user: GroupUserResponse) {
+		this.id = user.id;
+		this.firstName = user.firstName;
+		this.lastName = user.lastName;
+		this.role = user.role;
+	}
+}

apps/server/src/modules/group/controller/dto/response/group.response.ts

@@ -0,0 +1,33 @@
+import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
+import { ExternalSourceResponse } from './external-source.response';
+import { GroupTypeResponse } from './group-type.response';
+import { GroupUserResponse } from './group-user.response';
+
+export class GroupResponse {
+	@ApiProperty()
+	id: string;
+
+	@ApiProperty()
+	name: string;
+
+	@ApiProperty({ enum: GroupTypeResponse })
+	type: GroupTypeResponse;
+
+	@ApiProperty({ type: [GroupUserResponse] })
+	users: GroupUserResponse[];
+
+	@ApiPropertyOptional()
+	externalSource?: ExternalSourceResponse;
+
+	@ApiPropertyOptional()
+	organizationId?: string;
+
+	constructor(group: GroupResponse) {
+		this.id = group.id;
+		this.name = group.name;
+		this.type = group.type;
+		this.users = group.users;
+		this.externalSource = group.externalSource;
+		this.organizationId = group.organizationId;
+	}
+}

apps/server/src/modules/group/controller/dto/response/index.ts

@@ -1,2 +1,6 @@
 export * from './class-info.response';
 export * from './class-info-search-list.response';
+export * from './external-source.response';
+export * from './group.response';
+export * from './group-type.response';
+export * from './group-user.response';

apps/server/src/modules/group/controller/group.controller.ts

@@ -1,13 +1,13 @@
-import { Controller, Get, HttpStatus, Query } from '@nestjs/common';
+import { Controller, Get, HttpStatus, Param, Query } from '@nestjs/common';
 import { ApiOperation, ApiResponse, ApiTags } from '@nestjs/swagger';
 import { PaginationParams } from '@shared/controller';
 import { Page } from '@shared/domain';
 import { ErrorResponse } from '@src/core/error/dto';
 import { ICurrentUser } from '@src/modules/authentication';
 import { Authenticate, CurrentUser } from '@src/modules/authentication/decorator/auth.decorator';
 import { GroupUc } from '../uc';
-import { ClassInfoDto } from '../uc/dto';
-import { ClassInfoSearchListResponse, ClassSortParams } from './dto';
+import { ClassInfoDto, ResolvedGroupDto } from '../uc/dto';
+import { ClassInfoSearchListResponse, ClassSortParams, GroupIdParams, GroupResponse } from './dto';
 import { GroupResponseMapper } from './mapper';
 
 @ApiTags('Group')
@@ -43,4 +43,20 @@ export class GroupController {
 
 		return response;
 	}
+
+	@Get('/:groupId')
+	@ApiOperation({ summary: 'Get a group by id.' })
+	@ApiResponse({ status: HttpStatus.OK, type: GroupResponse })
+	@ApiResponse({ status: '4XX', type: ErrorResponse })
+	@ApiResponse({ status: '5XX', type: ErrorResponse })
+	public async getGroup(
+		@CurrentUser() currentUser: ICurrentUser,
+		@Param() params: GroupIdParams
+	): Promise<GroupResponse> {
+		const group: ResolvedGroupDto = await this.groupUc.getGroup(currentUser.userId, params.groupId);
+
+		const response: GroupResponse = GroupResponseMapper.mapToGroupResponse(group);
+
+		return response;
+	}
 }