Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-3513 Remove I-Prefix #4514

Merged
merged 119 commits into from
Nov 20, 2023
Merged

BC-3513 Remove I-Prefix #4514

merged 119 commits into from
Nov 20, 2023

Conversation

wolfganggreschus
Copy link
Contributor

@wolfganggreschus wolfganggreschus commented Nov 2, 2023 •
edited by atlldwp
Loading

Description

To improve code readability the devs in the architecuture meeting decided to remove all "I" prefix in the interface.

Links to Tickets or other pull requests

BC-3513

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@wolfganggreschus
IErrorType -> ErrorType
a534f54
@wolfganggreschus
ICoreModuleConfig -> CoreModuleConfig
fac77e3
@wolfganggreschus
IInterceptorConfig -> InterceptorConfig
6ef26a5
@wolfganggreschus
ILoggerConfig -> LoggerConfig
0d9cad5
@wolfganggreschus
IAccountConfig -> AccountConfig
4b1b2c8
@wolfganggreschus
ClassEntityProps, RepoLoader
8ea67c4
@wolfganggreschus
FileStorageConfig
4c60045
@wolfganggreschus
FileRecordSecurityCheckProperties, ParentInfo, FileRecordProperties
3e830fd
@wolfganggreschus
CopyFileDomainObjectProps, FileDomainObjectProps, CopyFilesRequestInf…
bc2271f 
…o, FileRequestInfo
@wolfganggreschus
FilesStorageClientConfig, FilesStorageClientConfig, CopyFileDomainObj…
48b3328 
…ectProps, FileDomainObjectProps, CommonCartridgeElement, CommonCartridgeElement

tests adjusted
@wolfganggreschus
Merge branch 'main' into BC-3513-remove-i-prefix-in-interfaces
5f38b88
@wolfganggreschus
solved some merge conflicts
af9b2cf
@wolfganggreschus
Merge branch 'main' into BC-3513-remove-i-prefix-in-interfaces
9b463e0
@wolfganggreschus
ILgecyLogger named temp LegacyLoggerInterface
14da120
@wolfganggreschus
ICalendarEvent -> CalendarEvent
d4db152
@wolfganggreschus
ICollaborativeStorageStrategy -> CollaborativeStorageStrategy
94b8412
@wolfganggreschus
IEncryptionService -> EncryptionService
1127a05
@wolfganggreschus
CollaborativeStorageStrategy - ModuleName changed
7ec975b
@wolfganggreschus
IIdentityManagementConfig -> IdentityManagementConfig
200c67a
@wolfganggreschus
IKeycloakSettings -> KeycloakSettingsInterface (temp)
58aa01a
@wolfganggreschus
renamed RetryOptions, MigrationOptions, CleanOptions
4a0d98e
@wolfganggreschus
IJsonAccount -> JsonAccount
00d9269
@wolfganggreschus
IJsonUser -> JsonUser
b71afc5
@wolfganggreschus
IKeycloakConfigurationInputFiles -> KeycloakConfigurationInputFilesIn…
e1c6ca5 
…terface (temp)
@wolfganggreschus
ICopyFilesOfParentParams > CopyFilesOfParentParams
142afeb 
IMailConfig -> MailConfig
IError -> ErrorInterface (temp)
@wolfganggreschus
IMailConfig -> MailConfig
7eed3b2
@wolfganggreschus
ICopyFileDO -> CopyFileDO
0c98f35
@wolfganggreschus
IFileDO -> FileDO
9ce7e25
@wolfganggreschus
ICurrentUserInterface -> CurrentUserInterface
7e4f9b2
@wolfganggreschus
ICurrentUser -> CurrentUserInterface (temp)
ea5cdc6
@wolfganggreschus
merged more conflicts caused by main-merge
184089d
@wolfganggreschus
adjusted tests
3e482c4
@wolfganggreschus
Adjusted more tests
a5b511b
@wolfganggreschus
Merge branch 'main' into BC-3513-remove-i-prefix-in-interfaces
b0b84db
@wolfganggreschus
specs adjusted
4cb6514
@wolfganggreschus
Merge branch 'BC-3513-remove-i-prefix-in-interfaces' of github.com:hp…
87c3979 
…i-schul-cloud/schulcloud-server into BC-3513-remove-i-prefix-in-interfaces
@wolfganggreschus
Merge branch 'main' into BC-3513-remove-i-prefix-in-interfaces
b4345b6
@wolfganggreschus
CurrentUserInterface -> ICurrentUser
e8460df
@wolfganggreschus
LegacyLoggerInterface -> ILegacyLogger
1b9eeae
@wolfganggreschus
KeycloakSettingsInterface -> IKeycloakSettings
bcc1c17
@wolfganggreschus
KeycloakConfigurationInputFilesInterface -> IKeycloakConfigurationInp…
0787195 
…utFiles
@wolfganggreschus
ErrorInterface -> IError
e95966e
@wolfganggreschus
ICommonCartridgeOrganizationBuilderInterface -> ICommonCartridgeOrgan…
1f191ce 
…izationBuilder
@wolfganggreschus
CommonCartridgeFileBuilderInterface -> ICommonCartridgeFileBuilder
1496805
@wolfganggreschus
ToolFeaturesInterface -> IToolFeatures
a250f22
@wolfganggreschus
BbbSettingsInterface -> IBbbSettings
76aa032
@wolfganggreschus
VideoConferenceSettingsInterface -> IVideoConferenceSettings
02b5679
@wolfganggreschus
GridElementInterface -> IGridElement
e70e5da
@wolfganggreschus
EntityInterface -> IEntity
991c351
@wolfganggreschus
ImportUserScopeInterface -> IImportUserScope
b547df5
@wolfganggreschus
TaskInterface -> ITask
51ac47d
@wolfganggreschus
NewsScopeInterface -> INewsScope
d7cc56d
@wolfganggreschus
DashboardRepoInterface -> IDashboardRepo
f9de095
@wolfganggreschus
Merge branch 'main' into BC-3513-remove-i-prefix-in-interfaces
468fb83
EzzatOmar
EzzatOmar approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@EzzatOmar EzzatOmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any new errors introduced.

apps/server/src/modules/authentication/services/authentication.service.spec.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes it is not the best idea to reorder imports in a big PR.
This can have sideeffects.

Try to remove these kind of changes in big PR. In small PR its okay as the search space is small

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@wolfganggreschus wolfganggreschus merged commit bbd7075 into main Nov 20, 2023
45 of 46 checks passed
@wolfganggreschus wolfganggreschus deleted the BC-3513-remove-i-prefix-in-interfaces branch November 20, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzatOmar EzzatOmar EzzatOmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfganggreschus @EzzatOmar