-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-5736 - Redis for tldraw #4542
Merged
+2,945
−844
Merged
Changes from 1 commit
Commits
Show all changes
453 commits
Select commit
Hold shift + click to select a range
f11d39f
Improve tests after merge.
blazejpass 6cb919e
Prevent from creating tldraw deploy and service
blazejpass 9be6bf4
Delete tldraw-deployment.yml.j2
blazejpass b2fd397
Use tldraw-test-module, improve code
blazejpass 7eecf87
Fix tests according to suggested comments.
blazejpass a9037cf
Change deployment yml to main
blazejpass 336de77
Fix code according to comments
blazejpass 7475bf5
Fix tests code according to comments. Move test helper
blazejpass 55ada6e
Merge remote-tracking branch 'origin/BC-4256-Integration-tldraw' into…
blazejpass 08ca974
Adjust code after merge changes from bc-4256
blazejpass 89c7816
Roll back for tldraw deployment and service declaration
blazejpass 31b4f20
Merge branch 'main' into BC-4710-new-tldraw-manage
blazejpass bcd3cbe
Adjust code after merge
blazejpass dc970fc
Add svc ang ingress rules for tldraw
blazejpass 491bcce
Change naming of uml files
blazejpass 4bc510f
Merge branch 'main' into BC-4710-new-tldraw-manage
blazejpass 6b16280
Fix import for module infra
blazejpass fcfb492
Fix lint suggestions. Fix module shared import.
blazejpass 8a73d1e
Lint fixes
blazejpass bddb1e4
Lint fixes
blazejpass 334b811
delete element auth fix
blazejpass ecd2e16
Add mock method destroy to createEsSharedDocDo
blazejpass 62a8676
Att test for recursive copy of drawing element
blazejpass 749e606
Merge branch 'main' into BC-4710-new-tldraw-manage
wiaderwek f98dcf6
Add ingress declaration
blazejpass b12eda6
Merge remote-tracking branch 'origin/BC-4710-new-tldraw-manage' into …
blazejpass 785714d
Merge branch 'main' into BC-4710-new-tldraw-manage
wiaderwek 962bbc2
add redis for tldraw
3778e89
fix imports
b84f001
temporary change clean.yml
blazejpass 981b677
Merge remote-tracking branch 'origin/BC-4710-new-tldraw-manage' into …
blazejpass 23bc570
change workflows for tests
044ee76
Merge branch 'BC-4710-new-tldraw-manage' into BC-5736-redis-for-tldraw
e234a64
add redis module
13cb011
add ioredis module
70b82d2
fix tests
a97b0a1
setup redis
2c590b4
install ioredis
079ca95
change ioredis version to 4.28.5
a5c55c1
remove usage redis module
0f29122
fix redis error
01127a3
add log
3621bc1
add debug logs
davwas cd115b0
add console logs
davwas fb75138
change log method
davwas 778ac27
remove duplicate logs
davwas cdd36de
add console logs again
davwas b78de7b
add more console logs
davwas e454d80
add more console logs 2
davwas 8e3c893
add more console logs 3
davwas 63b9623
add more console logs 4
davwas ccb48d0
fix wscheck
0f756b2
fix extracting channelId
ad2255f
fix extracting channelId
392e9a6
rewrite mongodbprovider to our code
3e0ca98
fix module configuration
ca6348d
fix module configuration
36c3a25
add mikro orm to tldraw ws module
f87bd99
clean up tldraw app code
davwas 1f2b628
update packages
davwas f3ec115
add tldraw again to npm scripts
davwas 6e1499c
add tldraw db and index creation
davwas a81e432
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas d041766
update tldraw collection names
davwas b797efa
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 5976c90
fix saving into db
davwas 9e1e044
remove unused code
b2c5c64
Merge branch 'main' into BC-5736-redis-for-tldraw
wiaderwek 20f370d
code refactor
a67ace0
code refactor v2
5c7b4cb
fix module and transaction error & clean up tldraw app code
davwas d82a5b4
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 561c5a3
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas e6f426b
fix problems after merge
davwas f908ca3
delete unused files and sync files
davwas 12f654f
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 2289de2
fix broken tests
davwas 217d1b3
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 3dca940
set default redis url if key not found
davwas eb4442f
fix code smells
davwas 1ff203e
add coverage tests
davwas 7034c55
refactor ws shared doc and add tests
davwas 7fc4561
add more coverage tests
davwas 346b9cd
fix spy method
davwas 155ade0
add coverage tests
davwas 34023fe
add missing method test
davwas edff1ab
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 403a4f5
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 8a52067
fix redisHandler error
davwas 522bffe
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 419a65f
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas ea25057
fix conflicts
davwas e8bbedc
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 23b6550
Update tldraw.repo.spec.ts
WojciechGrancow 241f6c7
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas f50b253
move env var to test config
davwas dedd070
Revert "move env var to test config"
davwas b7e0740
swap legacylogger with logger
davwas 698ea6b
fix imports
davwas 2684a5d
remove eslint comment
davwas 768eb17
remove tldraw db name from config
davwas f85ce21
move tldraw entity factory to testing, use it in entity tests
davwas af0e07e
change mockImplementation for mockResolved or mockRejected for promises
davwas 36548f1
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 29e873c
remove unused type
davwas 5b7f726
refactor ws-shared-doc-do and ws-service, refactor and add tests, add…
davwas 2ab745a
refactor tldraw entity, factory and creation of indexes
davwas 0077b02
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas b79857a
add missing tests
davwas 052fb37
add missing tests 2
davwas 0e7df0a
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 42ebc54
fix mongo connection error
davwas 53d8d15
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 8d1d8af
fix mongo error in tests
davwas 10f25a8
add more coverage tests
davwas 1ef4262
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas fedd7c7
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 668aeaf
add missing tests
davwas f46359a
fix test condition
davwas 344dc2b
fix wrong rabbit module import
davwas 67e7f8b
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas eb50a5a
add tldraw test config
davwas 7c3f6a1
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 0b403e3
fix import
davwas 66d613c
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 39d8c61
clean up tldraw env vars
davwas 3ee17c6
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 5f28d42
fix additional conflicts
davwas 77544e0
fix missing dependency
davwas 862f2ef
update websocket packages
davwas 0b0e05d
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 64d2b4d
fix package conflicts
davwas 0d14e90
solve merge conflicts
davwas f5986e4
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 060d31b
fix issues after merge
davwas 05278f5
fix import problems
davwas 8fb2451
fix missing imports in tests
davwas a7f2c36
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 9f86f19
fix other test issues
davwas a9ab05c
remove empty file
davwas fc44205
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas 880e087
fix comments
1408854
resolve comments
043a329
fix tests
e7002ed
add tldraw redis factory
f061629
fix tests
472ff24
fix tests
b7085fe
fix tests
930fe13
Merge branch 'main' into BC-5736-redis-for-tldraw
wiaderwek a043541
fix tests
7db1030
fix tests
41e98be
fix tests
75251c6
rerun
e8417cd
fix tests
803ef68
fix tests
683d9c2
fix tests
4a35e54
fix tests
a3af533
fix tests
7f1754d
Merge branch 'main' into BC-5736-redis-for-tldraw
4c0243e
fix tests
1e5fbcd
Merge branch 'main' into BC-5736-redis-for-tldraw
dc039d2
extend delay
92bb2d2
refactor tests
a981898
refactor tests
8d844bd
extend delay
ee8b497
extend delay
086eae1
extend delay
e12d193
fix tests
4128a4a
fix tests
a559a04
fix tests
8ff96ec
fix tests
e951ada
fix tests
3e9a6a6
add test
f3d9edd
fix test
ff5adde
fix test
11f67bb
extend timeout
8d0071b
add test
davwas 1fd16f0
remove duplicated test
davwas c6c696f
fix imports
davwas 5dd32b9
change delay
davwas d0fb99e
change redis subscribe method
davwas a320dd7
fix broken test
davwas 64c9dc4
Revert "change redis subscribe method"
davwas ef9f42f
change redis subscribe method
davwas 3fff2f1
change names
davwas 8ab87a5
add temporary log
davwas eaef660
change promises to async await
davwas 81eccdf
add diagnostic comments
davwas b51330a
fix tests
davwas 4fd5200
change publish signature
davwas f635f8e
fix tests, error casting
davwas e46dac3
fix test
davwas 485e7ff
add log
davwas 919f662
remove async redis calls
davwas f0bdd77
fix test
davwas 03877b0
add diagnostic log
davwas 6d0b8cc
fix tests and refactor
davwas 8b6c3b4
add diagnostic comment
davwas 88e5d63
yet another refactor
davwas 7d2f04a
fixes
davwas f390dfc
remove console logs
davwas 0ff9dc3
add access modifier
davwas c26084e
Merge branch 'main' into BC-5736-redis-for-tldraw
wiaderwek 5528da8
resolve comments
1710bc7
resolve comments
f1c137c
fix tests
ca7b607
fix tests
43fc03e
fix lint
3f9dbf7
resolve comments
565a02c
Merge branch 'main' into BC-5736-redis-for-tldraw
e6781a9
fix dependencies
35e5d38
add new test
0a2a508
rerun
8418ee7
fix tests
10d0a58
add test
4ecde56
add test
c90337c
add loggable
a79fa43
add test
a25b30b
fix test
ee70791
extend timeout
21b0b0d
fix dependencies
ecf7bb7
fix dependencies
686f248
Merge branch 'main' into BC-5736-redis-for-tldraw
wiaderwek 1f22f84
Merge branch 'main' into BC-5736-redis-for-tldraw
wiaderwek 4856615
extends delays
d5f8026
fix tests
fe7f7b5
fix tests
dd3f1e3
Proposal for outsource key creating code
CeEv f3039f9
fix typo
CeEv 0335c47
Fix code style
CeEv 634c3a6
Add factory tests.
CeEv 5edb111
restructure test code
CeEv 8f93b92
Rename factory
CeEv 047decf
renames
CeEv a6daad6
linter
CeEv 5770b49
linter again
CeEv 4ba46fd
linter
CeEv fb7c431
resolve comments
cd5499b
add tests
563a6fe
extend delay
a7fea9a
extend delay
1c22a21
fix tests
7c2a8ec
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas c14a101
fix bug where board was not being loaded correctly
davwas 4b750cb
fix test
davwas 977610a
fix lint
davwas dad583b
fix tests
davwas daa869c
fix tests
davwas c8d7acb
Merge branch 'main' into BC-5736-redis-for-tldraw
davwas b58d12e
Merge branch 'main' into BC-5736-redis-for-tldraw
wiaderwek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add coverage tests
commit 1ff203ebd1110cdc6830b779a3819656a0408862
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move the new TldrawDrawing behind a test factory with default values than is placed in modules/tldraw/testing/* . Can you also work with bson package new ObjectId().toHexString() for each id if it is a MongoDB objectId instead of generic string.
This factory can use existing production factories if it exists but pass default testing values to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done