BC-5268 move alert api to nest #4929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
wiaderwek
force-pushed
the
BC-5268-move-alert-to-nest
branch
from
059a650 to
f32f07c
Compare
davwas
reviewed
Apr 19, 2024
davwas
approved these changes
Apr 19, 2024
3 tasks
CeEv
requested changes
Apr 24, 2024
CeEv
requested changes
Apr 25, 2024
apps/server/src/modules/alert/controller/api-test/alert.api.spec.ts
Outdated
Show resolved
Hide resolved
CeEv
approved these changes
Apr 29, 2024
|
bergatco
pushed a commit
that referenced
this pull request
May 6, 2024
* BC-5268 move alert api to nest --------- Co-authored-by: Tomasz Wiaderek <[email protected]> Co-authored-by: Cedric Evers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QA note:
Change tested on env:
https://bc-5268-move-alert-to-nest.dbc.dbildungscloud.dev/
https://bc-5268-move-alert-to-nest.nbc.dbildungscloud.dev/
https://bc-5268-move-alert-to-nest.brb.dbildungscloud.dev/
No issues found. Tested for all users, everything works as on the main.
See ticket: https://ticketsystem.dbildungscloud.de/browse/BC-5268
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-5268
hpi-schul-cloud/nuxt-client#3205
hpi-schul-cloud/schulcloud-client#3442
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.