N21-2023 Add validity period provisioning to groups #5075
Conversation
apps/server/src/modules/provisioning/strategy/sanis/schulconnex-response-mapper.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/provisioning/strategy/sanis/schulconnex-response-mapper.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/provisioning/strategy/sanis/schulconnex-response-mapper.ts
Outdated
Show resolved
Hide resolved
apps/server/src/infra/schulconnex-client/response/schulconnex-laufzeit-response.ts
Show resolved
Hide resolved
|
Can you add "object: true" to @Embedded at entities in group.entity for validPeriod and also for externalSource?
|
|
|
||
| @IsOptional() | ||
| @IsString() | ||
| bislernperiode?: string; |
There was a problem hiding this comment.
It is possible to have a response with "von" and with "vonlernperiode" and "bislernperiode".
... "gruppe": { "id": "bc1036fb-9767-4ef0-8584-2a6c4941d954", "bezeichnung": "Gruppe_Test_X", "typ": "Klasse", "laufzeit": { "von": "2022-08-31", "vonlernperiode": "2022-1", "bislernperiode": "2024-2" }, "organisation": { "id": "a9a7d3f4-d4b0-4804-bf15-275637cb3bee", "kennung": "NI_00100", "name": "Testschulebfemaxypml_new", "typ": "Schule", "anschrift": { "ort": "Hannover" } } }, ....
At the moment the login fails with an validation error "property personenkontexte[0].gruppen[1].gruppe.laufzeit.von has failed the following constraints: von must be a Date instance".
You can use brando wolf and "Gruppe_Test_X"
|
|
||
| export class SchulconnexLaufzeitResponse { | ||
| @IsOptional() | ||
| @IsDate() |
There was a problem hiding this comment.
This is what we get from api: "2022-08-31" and the at moment the validation fails
|
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.