Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7390 - add schoolyears to adminapi created schools #5089

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

Metauriel
Copy link
Contributor

@Metauriel Metauriel commented Jun 28, 2024

Description

Links to Tickets or other pull requests.

BC-7390

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@hoeppner-dataport hoeppner-dataport changed the title add schoolyears to adminapi created schools BC-7390 - add schoolyears to adminapi created schools Jul 1, 2024
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem in file:
apps/server/src/modules/legacy-school/uc/admin-api-schools.uc.ts
The new service is only imported but not used.

@Metauriel Metauriel enabled auto-merge (squash) July 1, 2024 11:33
@Metauriel Metauriel disabled auto-merge July 1, 2024 14:49
@Metauriel Metauriel enabled auto-merge (squash) July 1, 2024 14:50
Copy link

sonarqubecloud bot commented Jul 2, 2024

@Metauriel Metauriel merged commit c4bb1fc into main Jul 2, 2024
54 checks passed
@Metauriel Metauriel deleted the BC-7390-fix-adminapi-schools branch July 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants