Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1825 Group UUID auto param for synced course #5155

Merged
merged 17 commits into from
Aug 6, 2024
Merged

N21-1825 Group UUID auto param for synced course #5155

merged 17 commits into from
Aug 6, 2024

Conversation

GordonNicholasCap
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap commented Jul 31, 2024 •
edited by MarvinOehlerkingCap
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@GordonNicholasCap GordonNicholasCap mentioned this pull request Jul 31, 2024
Merged
1 task
GordonNicholasCap and others added 13 commits August 1, 2024 12:16
@GordonNicholasCap
ensure moinschule_group_uuid auto param is always optional
d94dc06
@GordonNicholasCap
properly fetch syncedGroup from group service
f4cc5ef
@GordonNicholasCap
fix fetch external id
1547551
@GordonNicholasCap
Merge branch 'main' into N21-1825-sync-course-group-uuid-auto-param
a4de37f
@GordonNicholasCap
renamed auto param type to only AUTO_GROUP_UUID
a7db9ef
@GordonNicholasCap
added new tests & adapted existing ones
af8add5
@GordonNicholasCap
Merge remote-tracking branch 'refs/remotes/origin/main' into N21-1825-…
6fb0380 
…sync-course-group-uuid-auto-param
@GordonNicholasCap
N21-1825 added new tests for create external tool validator
cdf7231
@GordonNicholasCap
N21-1825 added special error for when auto param value cannot be filled
6bcd135
@GordonNicholasCap
N21-1825 reorder imports, fixed eslint errors
8ef509b
@GordonNicholasCap
N21-1825 re-allow non-optional auto group uuid tool
199b740
@GordonNicholasCap
N21-1825 renamed auto_groupuuid -> auto_group_externaluuid
b8c0a42
@GordonNicholasCap
Merge branch 'main' into N21-1825-sync-course-group-uuid-auto-param
78f7065
@GordonNicholasCap GordonNicholasCap mentioned this pull request Aug 6, 2024
Merged
3 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GordonNicholasCap GordonNicholasCap merged commit e584df2 into main Aug 6, 2024
54 of 55 checks passed
@GordonNicholasCap GordonNicholasCap deleted the N21-1825-sync-course-group-uuid-auto-param branch August 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonNicholasCap @MarvinOehlerkingCap