Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-835 provided courses API client and its adapter #5200

Merged
merged 44 commits into from
Sep 2, 2024
Merged

EW-835 provided courses API client and its adapter #5200

merged 44 commits into from
Sep 2, 2024

Conversation

Fshmit
Copy link
Contributor

@Fshmit Fshmit commented Aug 23, 2024

Description

In this ticket:

  1. Added a script (filter-spec.js) to filter the server's docs JSON
  2. Added a read me file under common-cartridge-client to describe the usage of the filter of spec
  3. Created an API Client by openapi for courses (CoursesApi)
  4. Created a client adapter to wrap the CoursesApi
  5. Implemented REST call through CoursesApi to get common cartridge metadata of a course from the schulcloud-server
  6. Modified the controller, use case and service of common-cartridge and expanded some tests

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/EW-835

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@Fshmit Fshmit self-assigned this Aug 23, 2024
@Fshmit Fshmit marked this pull request as ready for review August 27, 2024 08:25
Copy link

sonarqubecloud bot commented Sep 2, 2024

@Fshmit Fshmit merged commit ebd0fa4 into main Sep 2, 2024
83 checks passed
@Fshmit Fshmit deleted the EW-835 branch September 2, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants