BC-7904 - rename rooms endpoints #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
|
||
| describe(RoomBoardDTOFactory.name, () => { | ||
| let module: TestingModule; | ||
| let mapper: RoomBoardDTOFactory; | ||
| let roomsAuthorisationService: RoomsAuthorisationService; | ||
| let roomsAuthorisationService: CourseRoomsAuthorisationService; |
There was a problem hiding this comment.
not to important for the other "room..." variables in the other test files, but maybe for the auth service the distinction between roomsAuthorisationService and courseRoomsAuthorisationService might be important later on
There was a problem hiding this comment.
it is, that was why I renamed the CourseRoomsAuthorisationService itself, so we will have this clear distinction at the level of modules (services).
however, inside this file, the local var name is not relevant and was purposefully out of scope
MartinSchuhmacher
approved these changes
Aug 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
BC-7904
hpi-schul-cloud/nuxt-client#3374
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.