Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7881 - Create migration job for existing tldraw-docs from MongoDB to S3 #5212

Merged
merged 16 commits into from
Sep 4, 2024

Conversation

SevenWaysDP
Copy link
Contributor

@SevenWaysDP SevenWaysDP commented Aug 28, 2024

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@@ -1 +1,2 @@
export * from './tldraw-files.console';
export * from './tldraw-files.console';
export * from './tldraw-migration.console';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Braucht eigentlich nicht exportiert werden.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist aber nur aus ordner /job

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ja richtig

this.logger.log(res);
});

await Promise.all(promises);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte hier noch prüfen wie viel Dokumente je Instanz betroffen sind und wie groß die Gesamtgröße ist. Evtl. dann splitten. Momentan ist etwa bei 1,9 GB memory eine harte Grenze, die könnte man noch erhöhen, aber evtl. kann man auch gleich 100er Pakete nacheinander abarbeiten.

Der Job ist so geschrieben das wir ihn im Zweifelsfall nicht 2 mal ausführen können wenn es irgendwo harkt. Macht es leichter beim schreiben, aber erhöht das Risiko bei der Ausführung sehr deutlich. Dann müssen wir ihn vorher einmal jeweils mit jeder Prod DB Daten auf ein Dev System durchlaufen lassen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man kann diese Job mehrmals ausführen Yjs merged dann die alle elemente zusammen, aber ja muss nicht sein!

- secretRef:
name: api-files-secret
- secretRef:
name: tldraw-server-secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment that this is just for this job and should not be an example for anyone else

resources:
limits:
cpu: {{ API_CPU_LIMITS|default("2000m", true) }}
memory: {{ API_MEMORY_LIMITS|default("2Gi", true) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using different limits here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nein

Copy link

sonarqubecloud bot commented Sep 4, 2024

@SevenWaysDP SevenWaysDP merged commit af3e711 into main Sep 4, 2024
79 checks passed
@SevenWaysDP SevenWaysDP deleted the BC-7881 branch September 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants