-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-7881 - Create migration job for existing tldraw-docs from MongoDB to S3 #5212
Conversation
@@ -1 +1,2 @@ | |||
export * from './tldraw-files.console'; | |||
export * from './tldraw-files.console'; | |||
export * from './tldraw-migration.console'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Braucht eigentlich nicht exportiert werden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ist aber nur aus ordner /job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ja richtig
this.logger.log(res); | ||
}); | ||
|
||
await Promise.all(promises); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bitte hier noch prüfen wie viel Dokumente je Instanz betroffen sind und wie groß die Gesamtgröße ist. Evtl. dann splitten. Momentan ist etwa bei 1,9 GB memory eine harte Grenze, die könnte man noch erhöhen, aber evtl. kann man auch gleich 100er Pakete nacheinander abarbeiten.
Der Job ist so geschrieben das wir ihn im Zweifelsfall nicht 2 mal ausführen können wenn es irgendwo harkt. Macht es leichter beim schreiben, aber erhöht das Risiko bei der Ausführung sehr deutlich. Dann müssen wir ihn vorher einmal jeweils mit jeder Prod DB Daten auf ein Dev System durchlaufen lassen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man kann diese Job mehrmals ausführen Yjs merged dann die alle elemente zusammen, aber ja muss nicht sein!
- secretRef: | ||
name: api-files-secret | ||
- secretRef: | ||
name: tldraw-server-secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment that this is just for this job and should not be an example for anyone else
resources: | ||
limits: | ||
cpu: {{ API_CPU_LIMITS|default("2000m", true) }} | ||
memory: {{ API_MEMORY_LIMITS|default("2Gi", true) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using different limits here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nein
… uuid for S3 object name
…ction environment
…ction environment
Quality Gate passedIssues Measures |
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.