EW-998 created a new sync Module #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alweber-cap
approved these changes
Sep 6, 2024
| command: 'run <target>', | ||
| description: 'Starts the synchronization process.', | ||
| }) | ||
| public async startSync(target: string): Promise<void> { |
There was a problem hiding this comment.
what if target is empty?
There was a problem hiding this comment.
It is aborted with the error message "missing required argument "
alweber-cap
reviewed
Sep 6, 2024
| export class SyncService { | ||
| private strategies: Map<SyncStrategyTarget, SyncStrategy> = new Map<SyncStrategyTarget, SyncStrategy>(); | ||
|
|
||
| constructor(private readonly logger: Logger, @Optional() private readonly tspSyncStrategy?: TspSyncStrategy) { |
There was a problem hiding this comment.
this works alright wit hone strategy, but we need to find a better way if there is ever a second one
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this Ticket a new module for the TSP Sync is created. The module follows the same architectural concept as existing modules (console, services, etc.).
A Feature Flag for the TSP Sync is added to dof_app_deploy (see linked PR below)
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.