Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 404 on course page #5225

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix 404 on course page #5225

merged 3 commits into from
Sep 4, 2024

Conversation

Metauriel
Copy link
Contributor

@Metauriel Metauriel commented Sep 4, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@EzzatOmar EzzatOmar self-requested a review September 4, 2024 14:31
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 4, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Metauriel Metauriel merged commit 8030276 into main Sep 4, 2024
75 checks passed
@Metauriel Metauriel deleted the BC-8014-temporarily-accept-rooms-routes branch September 4, 2024 14:54
Metauriel added a commit that referenced this pull request Sep 4, 2024
@Metauriel
BC-8014 - fix 404 on course page (#5225)
13dd655 
* due to some caching issue, some clients still accessed old routes renamed by BC-7904.
This commit restores the old endpoints, which now exist alongside the new ones.
uidp added a commit that referenced this pull request Sep 6, 2024
@uidp
Revert "BC-8014 - fix 404 on course page (#5225)"
3a400da 
This reverts commit 8030276.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzatOmar EzzatOmar EzzatOmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Metauriel @EzzatOmar