Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring - Fully move System and User Import from @shared to @modules #5226

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Refactoring - Fully move System and User Import from @shared to @modules #5226

merged 5 commits into from
Sep 5, 2024

Conversation

sdinkov
Copy link
Contributor

@sdinkov sdinkov commented Sep 4, 2024 •
edited by GordonNicholasCap
Loading

Description

  • move ExternalSourceEmbeddable from groups domain to system module
  • move ImportUser entity and repo from shared to its module
  • move systemFactory from shared to module

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

GordonNicholasCap
GordonNicholasCap requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small changes needed

apps/server/src/modules/user-import/service/user-import.service.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-import/service/schulconnex-fetch-import-users.service.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-import/mapper/role-name.mapper.spec.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

GordonNicholasCap
GordonNicholasCap approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests ran by github actions did not failed, can be merged

@sdinkov sdinkov merged commit 0f9c2a6 into main Sep 5, 2024
75 checks passed
@sdinkov sdinkov deleted the N21-2108-refactoring-move-user-and-system-imports branch September 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonNicholasCap GordonNicholasCap GordonNicholasCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdinkov @GordonNicholasCap