EW-1007 decoupled course room dependency #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...src/modules/common-cartridge/common-cartridge-client/room-client/room-client.adapter.spec.ts
Dismissed
Show dismissed
Hide dismissed
...c/modules/common-cartridge/common-cartridge-client/room-client/courses-room-client.config.ts
Outdated
Show resolved
Hide resolved
...rver/src/modules/common-cartridge/common-cartridge-client/room-client/room-client.adapter.ts
Outdated
Show resolved
Hide resolved
psachmann
reviewed
Oct 2, 2024
psachmann
approved these changes
Oct 2, 2024
apps/server/src/modules/common-cartridge/common-cartridge-client/room-client/index.ts
Outdated
Show resolved
Hide resolved
...ules/common-cartridge/common-cartridge-client/room-client/mapper/board-element-dto.mapper.ts
Outdated
Show resolved
Hide resolved
mkreuzkam-cap
approved these changes
Oct 10, 2024
psachmann
approved these changes
Oct 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An API client for course-room Module is created. This can read Room data (Course structure including tasks, column boards and lessons IDs) from the schulcloud-server. A test endpoint is created which will be removed before merging this PR.
Links to Tickets or other pull requests
Ticket
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.