Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EW-1039 tsp client requesting access from tsp token endpoint #5273

Merged
merged 10 commits into from
Oct 8, 2024
Merged

EW-1039 tsp client requesting access from tsp token endpoint #5273

merged 10 commits into from
Oct 8, 2024

Conversation

psachmann
Copy link
Contributor

@psachmann psachmann commented Oct 2, 2024 •
edited
Loading

Description

Changing the authentication token generation for the TSP API client.

Links

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@psachmann psachmann self-assigned this Oct 2, 2024
@psachmann psachmann marked this pull request as ready for review October 2, 2024 12:27
@alweber-cap alweber-cap changed the title tsp client requesting access to from tsp token endpoint EW-1039 tsp client requesting access to from tsp token endpoint Oct 7, 2024
alweber-cap
alweber-cap requested changes Oct 7, 2024
View reviewed changes
temp.http Outdated Show resolved Hide resolved
apps/server/src/modules/server/server.config.ts Outdated Show resolved Hide resolved
@psachmann psachmann changed the title EW-1039 tsp client requesting access to from tsp token endpoint EW-1039 tsp client requesting access from tsp token endpoint Oct 8, 2024
@psachmann psachmann enabled auto-merge (squash) October 8, 2024 12:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@psachmann psachmann merged commit d95880a into main Oct 8, 2024
77 checks passed
@psachmann psachmann deleted the Ew-1039 branch October 8, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alweber-cap alweber-cap alweber-cap approved these changes

@SimoneRadtke-Cap SimoneRadtke-Cap SimoneRadtke-Cap approved these changes

Assignees

@psachmann psachmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psachmann @SimoneRadtke-Cap @alweber-cap