EW-1006: Add school part to TSP sync. #5279
Conversation
mkreuzkam-cap
changed the title
| imports: [ | ||
| LoggerModule, | ||
| ConsoleWriterModule, | ||
| ...((Configuration.get('FEATURE_TSP_SYNC_ENABLED') as boolean) |
There was a problem hiding this comment.
This is not very intuitive or expandable easily. But we have no other use for this currently, so it is ok
|
|
||
| const createdSchool = await this.tspSyncService.createSchool( | ||
| system, | ||
| tspSchool.schuleNummer ?? '', |
There was a problem hiding this comment.
I would argue that without schuleNummer the data is wrong and should be skipped and logged
| tokenEndpoint: system.oauthConfig?.tokenEndpoint ?? '', | ||
| }); | ||
|
|
||
| const lastChangeDate = this.formatChangeDate(new Date(0)); |
There was a problem hiding this comment.
Set this to a Date 25 hours in the past. Alternatively use an ENV_VAR on how far to go back in time
apps/server/src/infra/sync/tsp/loggable/tsp-system-not-found.loggable-exception.ts
Show resolved
Hide resolved
| } | ||
|
|
||
| public async updateSchool(school: School, name: string): Promise<School> { | ||
| school.name = name; |
There was a problem hiding this comment.
this will replace the name of the existing school with an empty name if there is no tspSchool.schuleName provided, should it do this?
There was a problem hiding this comment.
I think that is okay if that's the date sent from the TSP. Schulnummer like Alex pointed out would be more problematic
There was a problem hiding this comment.
I clarify this with PO
There was a problem hiding this comment.
If it is empty, please keep the old name
| export class TspSchulnummerMissingLoggable implements Loggable { | ||
| getLogMessage(): LogMessage { | ||
| const message: LogMessage = { | ||
| message: `A TSP school is missing a Schulnummer. Skipping school.`, |
There was a problem hiding this comment.
| message: `A TSP school is missing a Schulnummer. Skipping school.`, | |
| message: `A TSP school is missing a Schulnummer. This school is skipped`, |
| systemService.find.mockResolvedValueOnce([]); | ||
| }; | ||
|
|
||
| it('should throw', async () => { |
There was a problem hiding this comment.
| it('should throw', async () => { | |
| it('should throw a TspSystemNotFound exception', async () => { |
| export class TspSchulnummerMissingLoggable implements Loggable { | ||
| getLogMessage(): LogMessage { | ||
| const message: LogMessage = { | ||
| message: `A TSP school is missing a Schulnummer. This school is skipped.`, |
There was a problem hiding this comment.
After talking to PO, we can log the Schoolname here to help with support
|
Description
Adds the sync of schools in the new NestJS TSP Sync.
Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.