Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-2197 Course sync - Update existing course immediately after sync begin #5285

Closed
wants to merge 6 commits into from

Conversation

sdinkov
Copy link
Contributor

@sdinkov sdinkov commented Oct 9, 2024

Description

https://ticketsystem.dbildungscloud.de/browse/N21-2197

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

if (course.syncedWithGroup) {
throw new CourseAlreadySynchronizedLoggableException(course.id);
}

course.syncedWithGroup = group.id;
course.name = group.name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this logic in the schulconnex-course-sync.service.ts. We should not have the same logic twice.

Also I don't think the name should be updated for an existing course.

Copy link

@sdinkov sdinkov closed this Oct 10, 2024
@sdinkov sdinkov deleted the N21-2197-course-sync-update-existing-course branch October 10, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants