Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7960 - Move config api to tldraw server #5293

Merged
merged 20 commits into from
Oct 22, 2024
Merged

BC-7960 - Move config api to tldraw server #5293

merged 20 commits into from
Oct 22, 2024

Conversation

SevenWaysDP
Copy link
Contributor

@SevenWaysDP SevenWaysDP commented Oct 15, 2024 •
edited by bergatco
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

This was referenced Oct 16, 2024
Merged
Merged
bergatco
bergatco reviewed Oct 16, 2024
View reviewed changes
config/default.schema.json Outdated Show resolved Hide resolved
config/test.json Show resolved Hide resolved
@SevenWaysDP SevenWaysDP requested a review from bergatco October 16, 2024 07:10
@bergatco bergatco mentioned this pull request Oct 17, 2024
Closed
1 task
@SevenWaysDP SevenWaysDP enabled auto-merge (squash) October 22, 2024 13:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SevenWaysDP SevenWaysDP merged commit d567a04 into main Oct 22, 2024
75 checks passed
@SevenWaysDP SevenWaysDP deleted the BC-7960 branch October 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergatco bergatco bergatco approved these changes

Assignees

@SevenWaysDP SevenWaysDP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SevenWaysDP @bergatco