Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2026 preferred name #5295

Merged
merged 6 commits into from
Oct 16, 2024
Merged

N21-2026 preferred name #5295

merged 6 commits into from
Oct 16, 2024

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Oct 15, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

MarvinOehlerkingCap
MarvinOehlerkingCap requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the adjustments to the feathers user model

apps/server/src/shared/domain/entity/user.entity.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mrikallab mrikallab merged commit e67442f into main Oct 16, 2024
75 checks passed
@mrikallab mrikallab deleted the N21-2026-preferred-name branch October 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrikallab @MarvinOehlerkingCap