EW-1008 Decouple lesson dependency from common-cartridge module #5300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...modules/common-cartridge/common-cartridge-client/lesson-client/lesson-client.adapter.spec.ts
Fixed
Show fixed
Hide fixed
psachmann
requested changes
Oct 24, 2024
...ules/common-cartridge/common-cartridge-client/lesson-client/mapper/lesson-dto.mapper.spec.ts
Outdated
Show resolved
Hide resolved
...c/modules/common-cartridge/common-cartridge-client/lesson-client/mapper/lesson-dto.mapper.ts
Outdated
Show resolved
Hide resolved
...c/modules/common-cartridge/common-cartridge-client/lesson-client/mapper/lesson-dto.mapper.ts
Outdated
Show resolved
Hide resolved
...c/modules/common-cartridge/common-cartridge-client/lesson-client/mapper/lesson-dto.mapper.ts
Outdated
Show resolved
Hide resolved
...c/modules/common-cartridge/common-cartridge-client/lesson-client/mapper/lesson-dto.mapper.ts
Outdated
Show resolved
Hide resolved
.../src/modules/common-cartridge/common-cartridge-client/lesson-client/lesson-client.adapter.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/controller/common-cartridge.controller.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/controller/common-cartridge.controller.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Outdated
Show resolved
Hide resolved
HKayed
approved these changes
Oct 25, 2024
psachmann
reviewed
Oct 25, 2024
...c/modules/common-cartridge/common-cartridge-client/lesson-client/mapper/lesson-dto.mapper.ts
Outdated
Show resolved
Hide resolved
...modules/common-cartridge/common-cartridge-client/lesson-client/lesson-client.adapter.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/controller/common-cartridge.controller.ts
Outdated
Show resolved
Hide resolved
psachmann
reviewed
Oct 25, 2024
|
psachmann
approved these changes
Oct 25, 2024
hoeppner-dataport
pushed a commit
that referenced
this pull request
Oct 25, 2024
Add generated API for Lesson to decouple common cartridge module
HKayed
pushed a commit
that referenced
this pull request
Oct 28, 2024
Add generated API for Lesson to decouple common cartridge module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the microservice for Import/Export the LessonModule dependency has to be decoupled through HTTP Calls.
so we generate lesson client within common cartridge module and implement adapter for the lesson endpoints that common cartridge module use
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.