Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-1029 adding additional information for HTTP error logs #5305

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

psachmann
Copy link
Contributor

@psachmann psachmann commented Oct 22, 2024

Description

Enhancing the error logs for errors occurring in the NestJS HTTP context.

Datasecurity

For errors in the HTTP context we will log the userId, method, endpoint, params and query data.
UserId will only be logged if present.

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@psachmann psachmann self-assigned this Oct 22, 2024
@psachmann psachmann changed the title Ew 1029 copy EW-1029 adding additional information for HTTP error logs Oct 22, 2024
@psachmann psachmann marked this pull request as ready for review October 22, 2024 09:58
@Fshmit Fshmit self-requested a review October 23, 2024 10:46
@psachmann psachmann enabled auto-merge (squash) October 24, 2024 07:01
Copy link

@psachmann psachmann merged commit 19b5b97 into main Oct 24, 2024
75 checks passed
@psachmann psachmann deleted the EW-1029-copy branch October 24, 2024 07:31
hoeppner-dataport pushed a commit that referenced this pull request Oct 24, 2024
* Adding more information to HTTP error logs
HKayed pushed a commit that referenced this pull request Oct 24, 2024
* Adding more information to HTTP error logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants