EW-1009: Detach card dependency from boards #5306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...src/modules/common-cartridge/common-cartridge-client/card-client/card-client.adapter.spec.ts
Fixed
Show fixed
Hide fixed
Fshmit
reviewed
Oct 22, 2024
...c/modules/common-cartridge/common-cartridge-client/card-client/dto/timestamp-response.dto.ts
Outdated
Show resolved
Hide resolved
Fshmit
reviewed
Oct 22, 2024
...common-cartridge/common-cartridge-client/card-client/dto/visibility-settings-response.dto.ts
Outdated
Show resolved
Hide resolved
Fshmit
reviewed
Oct 22, 2024
...src/modules/common-cartridge/common-cartridge-client/card-client/card-client.adapter.spec.ts
Outdated
Show resolved
Hide resolved
Fshmit
reviewed
Oct 24, 2024
...artridge/common-cartridge-client/card-client/dto/submission-container-element-content.dto.ts
Outdated
Show resolved
Hide resolved
* Adding more information to HTTP error logs
Fshmit
reviewed
Oct 25, 2024
...rver/src/modules/common-cartridge/common-cartridge-client/card-client/card-client.adapter.ts
Outdated
Show resolved
Hide resolved
Fshmit
reviewed
Oct 25, 2024
apps/server/src/modules/common-cartridge/controller/common-cartridge.controller.ts
Outdated
Show resolved
Hide resolved
Add generated API for Lesson to decouple common cartridge module
* add preferred tool endpoint * add preferred tool uc * add apiProperty description * add seed data * add feature flag FEATURE_PREFERRED_CTL_TOOLS_ENABLED --------- Co-authored-by: Steliyan Dinkov <[email protected]> Co-authored-by: Igor Richter <[email protected]>
Fshmit
approved these changes
Oct 28, 2024
MajedAlaitwniCap
requested changes
Oct 28, 2024
.../modules/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.ts
Show resolved
Hide resolved
...les/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.spec.ts
Outdated
Show resolved
Hide resolved
...les/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.spec.ts
Outdated
Show resolved
Hide resolved
...les/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.spec.ts
Outdated
Show resolved
Hide resolved
...les/common-cartridge/common-cartridge-client/card-client/mapper/card-response.mapper.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.spec.ts
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.spec.ts
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/service/common-cartridge-export.service.ts
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/uc/common-cartridge.uc.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/common-cartridge/controller/common-cartridge.controller.ts
Outdated
Show resolved
Hide resolved
...src/modules/common-cartridge/common-cartridge-client/card-client/card-client.adapter.spec.ts
Outdated
Show resolved
Hide resolved
MajedAlaitwniCap
approved these changes
Oct 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is required to decouple the board card elements from the rest of the server to be available for usage as a standalone element used in the CC which can be later detached from the application.
Links to Tickets or other pull requests
Ticket
Changes
Datasecurity
No changes in data integrity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.