EW-1047: Add TSP System on Dev Environments #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mamutmk5
requested changes
Oct 29, 2024
ansible/roles/schulcloud-server-init/templates/configmap_file_init.yml.j2
Outdated
Show resolved
Hide resolved
| @@ -4,7 +4,7 @@ sonar.sources=. | |||
| sonar.tests=. | |||
| sonar.test.inclusions=**/*.spec.ts | |||
| sonar.exclusions=**/*.js,jest.config.ts,globalSetup.ts,globalTeardown.ts,**/*.app.ts,**/seed-data/*.ts,**/migrations/mikro-orm/*.ts,**/etherpad-api-client/**/*.ts,**/authorization-api-client/**/*.ts, **/course-api-client/**/*.ts,**/board-api-client/**/*.ts,**/generated/**/*.ts,**/room-api-client/**/*.ts,**/lessons-api-client/**/*.ts | |||
| sonar.coverage.exclusions=**/board-management.uc.ts,**/*.module.ts,**/*.factory.ts,**/migrations/mikro-orm/*.ts,**/globalSetup.ts,**/globalTeardown.ts,**/etherpad-api-client/**/*.ts,**/authorization-api-client/**/*.ts, **/course-api-client/**/*.ts,**/board-api-client/**/*.ts,**/generated/**/*.ts,**/room-api-client/**/*.ts | |||
| sonar.coverage.exclusions=**/board-management.uc.ts,**/*.module.ts,**/*.factory.ts,**/migrations/mikro-orm/*.ts,**/globalSetup.ts,**/globalTeardown.ts,**/etherpad-api-client/**/*.ts,**/authorization-api-client/**/*.ts, **/course-api-client/**/*.ts,**/board-api-client/**/*.ts,**/generated/**/*.ts,**/room-api-client/**/*.ts,apps/server/src/console/console.ts | |||
There was a problem hiding this comment.
Why exlude apps/server/src/console/console.ts from the code coverrage ?
There was a problem hiding this comment.
There isn't any test for this file as far as I can see and inside it are several more exclusions
There was a problem hiding this comment.
Not really scope of this ticket. Most of the console apps don't have tests
mamutmk5
requested changes
Nov 5, 2024
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-cronjob.yml.j2
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-init.yml.j2
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-init.yml.j2
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-init.yml.j2
Show resolved
Hide resolved
Co-authored-by: mamutmk5 <[email protected]>
mamutmk5
approved these changes
Nov 6, 2024
SimoneRadtke-Cap
approved these changes
Nov 6, 2024
WahlMartin
approved these changes
Nov 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TSP System on Dev Environments in the init scripts.
Also fixes:
Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.