Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-8187 - Creating and using boards in rooms #5313

Merged
merged 33 commits into from
Nov 8, 2024
Merged

BC-8187 - Creating and using boards in rooms #5313

merged 33 commits into from
Nov 8, 2024

Conversation

uidp
Copy link
Contributor

@uidp uidp commented Oct 25, 2024 •
edited
Loading

Description

As a teacher and student I want to be able to use a new single or multicolumn board within a room

Links to Tickets or other pull requests

BC-8187

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@uidp uidp added the WIP This feature branch is in progress, do not merge into master. label Oct 25, 2024
uidp and others added 19 commits October 28, 2024 17:26
@uidp
add api endpoint for getting room content
c9fa8b8
@uidp
Merge branch 'main' of github.com:hpi-schul-cloud/schulcloud-server i…
269354f 
…nto BC-8187-board-in-room
@uidp
refactor api from content to boards
e3fac0a
@uidp
refactor static method
9bd8bb3
@uidp
remove outdated TODO.md
516f5da
@uidp
update roles seeds
f8b8b95
@uidp
Merge branch 'main' of github.com:hpi-schul-cloud/schulcloud-server i…
1f962c4 
…nto BC-8187-board-in-room
@uidp
add room context to board context service
b068231
@uidp
Merge branch 'main' of github.com:hpi-schul-cloud/schulcloud-server i…
e51167f 
…nto BC-8187-board-in-room
@uidp
add missing module import
c8cd5df
@uidp
add board layout reponse property
0a81cc0
@uidp
update board layout api property
56b44a7
@uidp
Merge branch 'main' of github.com:hpi-schul-cloud/schulcloud-server i…
88be7ed 
…nto BC-8187-board-in-room
@MartinSchuhmacher
adding board context service tests for room context
5bfc888
@uidp
Merge branch 'BC-8187-board-in-room' of github.com:hpi-schul-cloud/sc…
8eabc7c 
…hulcloud-server into BC-8187-board-in-room
@uidp
add board room visibility response property
5df2644
@MartinSchuhmacher
Spliting board api tests between course and room context
5462261
@uidp
add roommember module to board ws api
2fb9f2b
@uidp
Merge branch 'main' of github.com:hpi-schul-cloud/schulcloud-server i…
9a7601c 
…nto BC-8187-board-in-room
@uidp uidp removed the WIP This feature branch is in progress, do not merge into master. label Nov 4, 2024
@uidp uidp enabled auto-merge (squash) November 6, 2024 14:10
EzzatOmar
EzzatOmar requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@EzzatOmar EzzatOmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code look fine. I just disagree with the board being imported in the room.
I think the board api should cover all cases to have it localized.

apps/server/src/modules/board/service/internal/board-context.service.ts Show resolved Hide resolved
apps/server/src/modules/board/uc/board.uc.ts Show resolved Hide resolved
apps/server/src/modules/room-member/service/room-member.service.ts Show resolved Hide resolved
apps/server/src/modules/room/api/room.controller.ts Outdated Show resolved Hide resolved
apps/server/src/modules/room/room-api.module.ts Show resolved Hide resolved
@EzzatOmar EzzatOmar self-requested a review November 7, 2024 15:41
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@uidp uidp merged commit ac0f0dc into main Nov 8, 2024
77 checks passed
@uidp uidp deleted the BC-8187-board-in-room branch November 8, 2024 14:29
hoeppner-dataport pushed a commit that referenced this pull request Nov 18, 2024
@uidp @MartinSchuhmacher @hoeppner-dataport
BC-8187 - Creating and using boards in rooms (#5313)
eca5809 
* implement board creation in room

* add api endpoint for getting room boards

* add room context to board context service

* add tests

---------

Co-authored-by: MartinSchuhmacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzatOmar EzzatOmar EzzatOmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uidp @EzzatOmar @MartinSchuhmacher