Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8354 - adjust roles cache to use different tokens for different operations #5322

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

Metauriel
Copy link
Contributor

@Metauriel Metauriel commented Nov 5, 2024

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@Metauriel Metauriel enabled auto-merge (squash) November 5, 2024 10:30
@hoeppner-dataport hoeppner-dataport changed the title adjust roles cache to use different tokens for different operations BC-8354 - adjust roles cache to use different tokens for different operations Nov 5, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

@Metauriel Metauriel merged commit 1767779 into main Nov 5, 2024
75 of 76 checks passed
@Metauriel Metauriel deleted the BC-8354-adjust-role-cache branch November 5, 2024 15:19
Metauriel added a commit that referenced this pull request Nov 6, 2024
…erations (#5322)

in the roles repo, findByNames and findByName used the same cache result (when only a single roleName was selected). This resulted in an error, when an array result was expected but the cache contained a single result, or when a single result was expected but cache contained an array with a single element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants