Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8362 - RoomMember groups are shown in class administration #5324

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Nov 6, 2024

Description

Within NBC classes are also known as groups. Within that setting, group belonging to the new RoomMember(ship) Entity are also shown there. As for now the business case, where and how to show these new groups is not finally decided, we should filter the classes/groups for only the class type and remove the ones, belonging to the new type rooms.

Links to Tickets or other pull requests

BC-8362

Changes

  • filter groups for group type class status in BE

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher self-assigned this Nov 6, 2024
Copy link

sonarqubecloud bot commented Nov 7, 2024

@MartinSchuhmacher MartinSchuhmacher merged commit f6cb184 into main Nov 7, 2024
77 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-8362-class-admin branch November 7, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants